From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: [PATCH 3/4] Import BSD functions defined in <netinet/ether.h> from NetBSD
Date: Sat, 20 Oct 2012 20:48:41 -0400 [thread overview]
Message-ID: <20121021004841.GY254@brightrain.aerifal.cx> (raw)
In-Reply-To: <50834745.7090307@embtoolkit.org>
On Sun, Oct 21, 2012 at 02:52:21AM +0200, Abdoulaye Walsimou GAYE wrote:
> >why do you duplicate the code and not use simply the _r functions from [4/4] with the static buffer ?
> >btw the usage of sscanf is both bloated and slow.
>
> This was for record of the original code from NetBSD, before
> patching it in [4/4]
Understood.
> >anyway, i doubt it makes sense to add this crap; i never needed it
> >for sabotage which is almost feature complete and compiles 250
> >packages.
>
> I can not argue with this kind of comments.
Apologies; some members of our community are a bit abrasive at times,
and I think your initial insistence on the cdefs.h thing (which was
discussed to death in the past) got a few ppl irritated.
I have no objection to the basic functionality as long as it's done in
a way that's clean and unobtrusive. I think it would be nice to know
what apps/libs need it though, as a justification. Additions like this
(i.e. functions not required by the standards and not widely used)
should be documented as added "because it's needed by such-and-such"
rather than "just because we can".
Rich
next prev parent reply other threads:[~2012-10-21 0:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 20:15 [PATCH 0/4] Import <netinet/ether.h> features " Abdoulaye Walsimou Gaye
2012-10-20 20:15 ` [PATCH 1/4] Build system: give ability to install lib/crt*.o files separately Abdoulaye Walsimou Gaye
2012-10-20 23:49 ` Rich Felker
2012-10-20 20:15 ` [PATCH 2/4] Add basic sys/cdefs.h found on most unix Abdoulaye Walsimou Gaye
2012-10-20 23:18 ` Isaac Dunham
2012-10-20 23:38 ` Abdoulaye Walsimou GAYE
2012-10-20 23:38 ` Rich Felker
2012-10-21 0:13 ` Abdoulaye Walsimou GAYE
2012-10-21 0:11 ` Rich Felker
2012-10-21 0:38 ` Abdoulaye Walsimou GAYE
2012-10-21 0:39 ` John Spencer
2012-10-21 1:21 ` John Spencer
2012-10-20 23:50 ` Isaac Dunham
2012-10-20 23:44 ` Rich Felker
2012-10-20 20:15 ` [PATCH 3/4] Import BSD functions defined in <netinet/ether.h> from NetBSD Abdoulaye Walsimou Gaye
2012-10-20 23:37 ` idunham
2012-10-21 0:40 ` Abdoulaye Walsimou GAYE
2012-10-21 0:42 ` John Spencer
2012-10-21 0:41 ` Rich Felker
2012-10-21 0:52 ` Abdoulaye Walsimou GAYE
2012-10-21 0:48 ` Rich Felker [this message]
2012-10-21 0:57 ` John Spencer
2012-10-21 0:53 ` Rich Felker
2012-10-20 20:15 ` [PATCH 4/4] <netinet/ether.h>: Add GNU extensions ether_ntoa_r() and ether_aton_r() Abdoulaye Walsimou Gaye
2012-10-20 23:53 ` Rich Felker
2012-10-21 0:43 ` Abdoulaye Walsimou GAYE
2012-10-21 0:46 ` John Spencer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121021004841.GY254@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).