mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: type of wchar_t
Date: Thu, 15 Nov 2012 08:26:03 -0500	[thread overview]
Message-ID: <20121115132603.GG20323@brightrain.aerifal.cx> (raw)
In-Reply-To: <20121115163631.0db22beb@keeper.home.local>

On Thu, Nov 15, 2012 at 04:36:31PM +0400, Yuri Kozlov wrote:
> > so we either use the __WCHAR_TYPE__ defined by the
> > compiler (when it's defined), or use the abi specs
> > (which gives the align+size+sign information and
> > hopefully compilers agree on a single int type when
> > there are multiple choices)
> 
> Thanks for clarification.
> Hah, gcc emit a __WCHAR_TYPE__ for arm as unsigned. Wow.
> $ arm-linux-gnueabi-gcc -dM -E - < /dev/null |grep __WCHAR_T
> #define __WCHAR_TYPE__ unsigned int

Yes. Whoever designed this aspect of the ARM EABI did not know what
they were doing. They probably came from a Windows background where
wchar_t is unsigned short (to be able to represent all of the Unicode
BMP) and did not realize that making it unsigned is unnecessary and
even harmful when it's 32-bit and thus able to store all of Unicode
(and much more) in a signed type.

As already explained, I wanted to just always use a signed type on
musl, but since L"" must match the type of wchar_t* (otherwise,
passing L"" to a function that expects wchar_t* is a constraint
violation and the compiler should throw an error), we need the
definition to agree with whatever the compiler thinks it is, and
real-world compilers follow the EABI document that defines it as
unsigned.

Rich


      reply	other threads:[~2012-11-15 13:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15  9:09 Yuri Kozlov
2012-11-15 11:53 ` Szabolcs Nagy
2012-11-15 12:36   ` Yuri Kozlov
2012-11-15 13:26     ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121115132603.GG20323@brightrain.aerifal.cx \
    --to=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).