From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: src/stdio/__stdio_read.c
Date: Fri, 16 Nov 2012 14:01:21 -0500 [thread overview]
Message-ID: <20121116190121.GQ20323@brightrain.aerifal.cx> (raw)
In-Reply-To: <20121116092936.GI12537@port70.net>
On Fri, Nov 16, 2012 at 10:29:36AM +0100, Szabolcs Nagy wrote:
> * Yuri Kozlov <yuray@komyakino.ru> [2012-11-16 11:40:57 +0400]:
> > size_t __stdio_read(FILE *f, unsigned char *buf, size_t len)
> > {
> > ssize_t cnt;
> > ...
> > cnt = syscall(SYS_readv, ...)
> >
> > if (cnt <= 0) {
> > f->flags |= F_EOF ^ ((F_ERR^F_EOF) & cnt);
> > f->rpos = f->rend = 0;
> > return cnt;
> > }
> > ...
> > }
> >
> > It not raise a problem when a signed value return as unsigned?
> >
>
> no, cnt is either 0 or -1 there (assuming readv works)
>
> this is how __stdio_read is used (f->read):
>
> for (; l; l-=k, dest+=k) {
> k = __toread(f) ? 0 : f->read(f, dest, l);
> if (k+1<=1) {
> FUNLOCK(f);
> return (len-l)/size;
> }
> }
>
> it handles the k == -1 and k == 0 case
As far as I can tell, it would work just fine to have the f->read
function simply return 0 on both EOF and error; there do not seem to
be any callers that care to distinguish these cases. When I get around
to documenting stdio internals I might clean up some things like this.
Rich
prev parent reply other threads:[~2012-11-16 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 7:40 src/stdio/__stdio_read.c Yuri Kozlov
2012-11-16 9:29 ` src/stdio/__stdio_read.c Szabolcs Nagy
2012-11-16 19:01 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116190121.GQ20323@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).