FreeSWITCH build, timerfd macros

FreeSWITCH build, timerfd macros

[ojab]

Hi list,

glibc's timerfd.h has some defines, which doesn't exist in musl.

One of them — TFD_TIMER_ABSTIME, which is basically
#define TFD_TIMER_ABSTIME (1 << 0)

is used by FreeSWITCH, so right now FS build fails with
> src/switch_time.c:827:29: error: 'TFD_TIMER_ABSTIME' undeclared (first use in this function)

Can this macro be added to musl?

//wbr ojab

Re: FreeSWITCH build, timerfd macros

[John Spencer]

On 12/13/2012 12:23 PM, ojab wrote:
> Hi list,
>
> glibc's timerfd.h has some defines, which doesn't exist in musl.
>
> One of them — TFD_TIMER_ABSTIME, which is basically
> #define TFD_TIMER_ABSTIME (1 << 0)
>
> is used by FreeSWITCH, so right now FS build fails with
>> src/switch_time.c:827:29: error: 'TFD_TIMER_ABSTIME' undeclared 
>> (first use in this function)

to make it work you can simply add -DTFD_TIMER_ABSTIME=1 to your CFLAGS.
for example:
CFLAGS="-DTFD_TIMER_ABSTIME=1" ./configure --blah --blah

Re: FreeSWITCH build, timerfd macros

[Rich Felker]

On Thu, Dec 13, 2012 at 06:28:18PM +0100, John Spencer wrote:
> On 12/13/2012 12:23 PM, ojab wrote:
> >Hi list,
> >
> >glibc's timerfd.h has some defines, which doesn't exist in musl.
> >
> >One of them — TFD_TIMER_ABSTIME, which is basically
> >#define TFD_TIMER_ABSTIME (1 << 0)
> >
> >is used by FreeSWITCH, so right now FS build fails with
> >>src/switch_time.c:827:29: error: 'TFD_TIMER_ABSTIME' undeclared
> >>(first use in this function)
> 
> to make it work you can simply add -DTFD_TIMER_ABSTIME=1 to your CFLAGS.
> for example:
> CFLAGS="-DTFD_TIMER_ABSTIME=1" ./configure --blah --blah

Yes, but this macro is obviously supposed to be defined in timerfd.h.
Are there any other macros we should add there at the same time?

Rich

Re: FreeSWITCH build, timerfd macros

[ojab]

On 13.12.2012 22:59, Rich Felker wrote:
> On Thu, Dec 13, 2012 at 06:28:18PM +0100, John Spencer wrote:
>> On 12/13/2012 12:23 PM, ojab wrote:
>>> Hi list,
>>>
>>> glibc's timerfd.h has some defines, which doesn't exist in musl.
>>>
>>> One of them — TFD_TIMER_ABSTIME, which is basically
>>> #define TFD_TIMER_ABSTIME (1 << 0)
>>>
>>> is used by FreeSWITCH, so right now FS build fails with
>>>> src/switch_time.c:827:29: error: 'TFD_TIMER_ABSTIME' undeclared
>>>> (first use in this function)
>>
>> to make it work you can simply add -DTFD_TIMER_ABSTIME=1 to your CFLAGS.
>> for example:
>> CFLAGS="-DTFD_TIMER_ABSTIME=1" ./configure --blah --blah
>
> Yes, but this macro is obviously supposed to be defined in timerfd.h.
> Are there any other macros we should add there at the same time?
>
> Rich
>

There is also
/* Bits to be set in the FLAGS parameter of `timerfd_create'.  */
enum
   {
     TFD_CLOEXEC = 02000000,
#define TFD_CLOEXEC TFD_CLOEXEC
     TFD_NONBLOCK = 00004000
#define TFD_NONBLOCK TFD_NONBLOCK
   };

in glibc sources.

//wbr ojab

Re: FreeSWITCH build, timerfd macros

[Rich Felker]

On Thu, Dec 13, 2012 at 11:07:42PM +0400, ojab wrote:
> There is also
> /* Bits to be set in the FLAGS parameter of `timerfd_create'.  */
> enum
>   {
>     TFD_CLOEXEC = 02000000,
> #define TFD_CLOEXEC TFD_CLOEXEC
>     TFD_NONBLOCK = 00004000
> #define TFD_NONBLOCK TFD_NONBLOCK
>   };
> 
> in glibc sources.

OK, I will add these, presuming the values vary by arch to match the
corresponding O_* constants from fcntl.h. If that's incorrect, please
let me know.

Rich