mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: spandsp build, lrint/sqrt/pow issue
Date: Fri, 14 Dec 2012 14:33:42 +0100	[thread overview]
Message-ID: <20121214133342.GQ23126@port70.net> (raw)
In-Reply-To: <50CB22CD.1070208@ojab.ru>

* ojab <ojab@ojab.ru> [2012-12-14 16:59:57 +0400]:
> Thanks for the quick fix, lrint issue is fixed. Right now build
> fails only on sqrt() and pow():
> awgn.c: In function 'awgn_init_dbov':
> awgn.c:109:14: warning: cast to pointer from integer of different size
> awgn.c:109:14: warning: cast to pointer from integer of different size
> awgn.c:109:14: warning: cast to pointer from integer of different size
> awgn.c:109:5: error: void value not ignored as it ought to be
> 
> and line 109:
>   s->rms = pow(10.0, level/20.0)*32768.0;
> 
> 
> Next issue is
> awgn.c: In function 'awgn':
> awgn.c:165:15: warning: cast to pointer from integer of different size
> awgn.c:165:15: warning: cast to pointer from integer of different size
> awgn.c:165:9: error: void value not ignored as it ought to be
> awgn.c:165:9: warning: type defaults to 'int' in type name
> 
> and line 165:
>         fac = sqrt(-2.0*log(r)/r);
> 

both of these expressions work here (i386, gcc-4.4)

i think your compiler does not like the tgmath __RETCAST magic
and i have no idea what went wrong

> So I suppose the fix is needed (don't know if it should be on musl
> side though).
> spandsp use tgmath.h only if available, so if I'll remove tgmath.h
> or undefine HAVE_TGMATH_H ? spandsp builds fine.

my point is that they shouldn't use it at all
(at least not in that particular translation unit, it's not wrong,
but pointless, it just makes compilation slow and fragile)


  reply	other threads:[~2012-12-14 13:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-14  9:49 ojab
2012-12-14 12:40 ` Szabolcs Nagy
2012-12-14 12:59   ` ojab
2012-12-14 13:33     ` Szabolcs Nagy [this message]
2012-12-14 14:21       ` ojab
2012-12-14 19:47         ` ojab
2012-12-15  0:47           ` Szabolcs Nagy
2012-12-16 10:29             ` ojab
2012-12-16 14:12               ` Szabolcs Nagy
2012-12-18  6:07                 ` ojab
2012-12-18 11:45                   ` Szabolcs Nagy
2012-12-18 12:31                     ` Szabolcs Nagy
2012-12-18 13:50                       ` Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121214133342.GQ23126@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).