From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/2471 Path: news.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: spandsp build, lrint/sqrt/pow issue Date: Fri, 14 Dec 2012 14:33:42 +0100 Message-ID: <20121214133342.GQ23126@port70.net> References: <50CAF645.9000804@ojab.ru> <20121214124026.GO23126@port70.net> <50CB22CD.1070208@ojab.ru> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1355492044 19541 80.91.229.3 (14 Dec 2012 13:34:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 14 Dec 2012 13:34:04 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-2472-gllmg-musl=m.gmane.org@lists.openwall.com Fri Dec 14 14:34:17 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1TjVOz-0000St-Ng for gllmg-musl@plane.gmane.org; Fri, 14 Dec 2012 14:34:09 +0100 Original-Received: (qmail 25891 invoked by uid 550); 14 Dec 2012 13:33:53 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 25883 invoked from network); 14 Dec 2012 13:33:53 -0000 Content-Disposition: inline In-Reply-To: <50CB22CD.1070208@ojab.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:2471 Archived-At: * ojab [2012-12-14 16:59:57 +0400]: > Thanks for the quick fix, lrint issue is fixed. Right now build > fails only on sqrt() and pow(): > awgn.c: In function 'awgn_init_dbov': > awgn.c:109:14: warning: cast to pointer from integer of different size > awgn.c:109:14: warning: cast to pointer from integer of different size > awgn.c:109:14: warning: cast to pointer from integer of different size > awgn.c:109:5: error: void value not ignored as it ought to be > > and line 109: > s->rms = pow(10.0, level/20.0)*32768.0; > > > Next issue is > awgn.c: In function 'awgn': > awgn.c:165:15: warning: cast to pointer from integer of different size > awgn.c:165:15: warning: cast to pointer from integer of different size > awgn.c:165:9: error: void value not ignored as it ought to be > awgn.c:165:9: warning: type defaults to 'int' in type name > > and line 165: > fac = sqrt(-2.0*log(r)/r); > both of these expressions work here (i386, gcc-4.4) i think your compiler does not like the tgmath __RETCAST magic and i have no idea what went wrong > So I suppose the fix is needed (don't know if it should be on musl > side though). > spandsp use tgmath.h only if available, so if I'll remove tgmath.h > or undefine HAVE_TGMATH_H ? spandsp builds fine. my point is that they shouldn't use it at all (at least not in that particular translation unit, it's not wrong, but pointless, it just makes compilation slow and fragile)