From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: Compatability: aufs-utils needs GNU extensions to nftw
Date: Tue, 1 Jan 2013 20:27:30 -0500 [thread overview]
Message-ID: <20130102012730.GR20323@brightrain.aerifal.cx> (raw)
In-Reply-To: <14643.50.0.224.127.1357079616.squirrel@lavabit.com>
On Tue, Jan 01, 2013 at 02:33:36PM -0800, idunham@lavabit.com wrote:
> One of the Puppy developers recently mentioned that he'd like to build
> mount.aufs with musl because the static binary is excessively large (600
> kb) when built with glibc.
> However, there are a couple issues:
> 1. The most important issue is that libau uses the following flags/macros:
> FTW_ACTIONRETVAL
> FTW_CONTINUE
> FTW_SKIP_SUBTREE
> FTW_SKIP
Are you sure it really _needs_ them? They seem to be mostly
optimizations to avoid walking uninteresing parts of the tree, and it
should be possible to achieve the same behavior (aside from time
wasted walking uninteresting stuff) with minor changes to the callback
function...
> >From all I can see, this would require some extensions to nftw() and
> possibly to fn().
> I'm not sure exactly what glibc does with these, so I have no idea what to
> do.
This doesn't seem so bad, and probably could be added. But I'd like to
overhaul ftw anyway to use the *at functions instead of concatenating
paths, and to avoid recursion, and to handle the fd limit right. At
present I would say we have a very poor implementation. On the bright
side, these functions are so bad that correct software should not be
using them; they don't pass any context back to the callback, so the
only way to use them is with global or thread-local vars...
Rich
next prev parent reply other threads:[~2013-01-02 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-01 22:33 idunham
2013-01-02 1:27 ` Rich Felker [this message]
2013-01-02 11:59 ` James B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130102012730.GR20323@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).