mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: minor issues (found by cppcheck)
Date: Mon, 14 Jan 2013 20:41:47 +0100	[thread overview]
Message-ID: <20130114194147.GW4468@port70.net> (raw)

i fixed some minor issues in my repo which were found by cppcheck
here is a list of the non-fixed ones:


[src/misc/mntent.c:32]: (portability) scanf without field width limits can crash with huge input data

getmntent_r has a sscanf with %d,
it might make sense to limit the width


[src/regex/regcomp.c:2032]: (performance) Variable 'status' is reassigned a value before the old one has been used.
[src/regex/regcomp.c:3133]: (warning) Redundant assignment of 'errcode' to itself.
[src/regex/regcomp.c:2060]: (style) Variable 'minimal_tag' is assigned a value that is never used.
[src/regex/regcomp.c:108]: (style) struct or union member 'Anonymous1::params' is never used.
[src/regex/regcomp.c:2803]: (error) Uninitialized variable: params

some of these occure multiple times,
the last two is probably worth fixing:
u.params in tre_literal_t struct is never used
and in the tre_match_empty function the params
argument is never used, but an uninitialized
pointer is passed anyway


[src/locale/strfmon.c:33]: (style) Variable 'fill' is assigned a value that is never used.
[src/stdio/vfscanf.c:134]: (style) Variable 'alloc' is assigned a value that is never used.
[src/stdio/vfwscanf.c:144]: (style) Variable 'alloc' is assigned a value that is never used.

these are examples of unused values but they
all seem to be innocent


             reply	other threads:[~2013-01-14 19:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 19:41 Szabolcs Nagy [this message]
2013-01-14 21:05 ` Rich Felker
2013-01-14 21:23   ` Szabolcs Nagy
2013-01-14 21:57     ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130114194147.GW4468@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).