mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: minor issues (found by cppcheck)
Date: Mon, 14 Jan 2013 22:23:50 +0100	[thread overview]
Message-ID: <20130114212350.GX4468@port70.net> (raw)
In-Reply-To: <20130114210541.GQ20323@brightrain.aerifal.cx>

* Rich Felker <dalias@aerifal.cx> [2013-01-14 16:05:41 -0500]:
> On Mon, Jan 14, 2013 at 08:41:47PM +0100, Szabolcs Nagy wrote:
> > getmntent_r has a sscanf with %d,
> > it might make sense to limit the width
> 
> I think the error is irrelevant for %d unless we're talking about the
> theoretical UB for integer overflow, but that doesn't seem to be what
> this warning is about. Anyway, musl's scanf has well-defined overflow
> behavior.

i mean if there is a very long digit sequence in the input
it may make sense to fail early, eg use %11d and with a final
%n we could check if the input is read correctly

assuming we want to report failure on invalid input


  reply	other threads:[~2013-01-14 21:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 19:41 Szabolcs Nagy
2013-01-14 21:05 ` Rich Felker
2013-01-14 21:23   ` Szabolcs Nagy [this message]
2013-01-14 21:57     ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130114212350.GX4468@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).