Re: Bug in include/netinet/in.h

[Rich Felker <dalias@aerifal.cx>]

On Thu, Jan 24, 2013 at 08:22:03PM +0100, Alexander Stadler wrote:
> Am 23.01.2013 18:11, schrieb Rich Felker:
> > On Wed, Jan 23, 2013 at 05:58:13PM +0100, John Spencer wrote:
> >> On 01/23/2013 05:39 PM, Alexander Stadler wrote:
> >>> [-Werror=parentheses]
> >>> /space/build-trunk/trunk/build_dir/target-mips_r2_musl-0.9.8/netifd-2013-01-22.1/interface-ip.c:655:2: error: suggest parentheses around arithmetic in operand of '|' [-Werror=parentheses]
> >>> cc1: all warnings being treated as errors
> >> the bug here is -Werror being passed to the compiler, try adding
> >> --disable-werror to the configure invocation
> >>
> >> (note: using -Werror by default is pretty inept, since it will cause
> >> build errors on any compiler/libc combination that has not yet been
> >> tested by the package author)
> > 
> > Normally these kind of warnings are ignored in the system headers and
> > macro text expanded from macros defined in the system headers. I don't
> > see any reason we can't "fix" this particular macro however if for
> > some reason it's still making trouble..
> > 
> > Rich
> 
> I removed -Werror from CMakeLists.txt of netifd, after that it compiled (with warnings ;-) ).
> Thank you!
> 
> (only size shocked me - 450KB (one day before with uClibc 50KB :-/ ))

You must have been dynamic linking with uClibc and static linking with
musl -- and linking some libs other than just libc statically, I
think, since even the whole libc is not that big.

Rich