mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: [PATCH] move the definition of __pthread_tsd_main in the only compilation unit that references it
Date: Mon, 11 Feb 2013 11:24:16 +0100	[thread overview]
Message-ID: <20130211102415.GZ6181@port70.net> (raw)
In-Reply-To: <1360574285.9132.14.camel@eris.loria.fr>

* Jens Gustedt <Jens.Gustedt@inria.fr> [2013-02-11 10:19:44 +0100]:
> This also avoids a const cast that doesn't seem to be very useful.
> 
> 0	3	src/thread/pthread_key_create.c
> 4	4	src/thread/pthread_self.c
> 
> diff --git a/src/thread/pthread_key_create.c b/src/thread/pthread_key_create.c
> index e51cb02..084cbaa 100644
> --- a/src/thread/pthread_key_create.c
> +++ b/src/thread/pthread_key_create.c
> @@ -1,8 +1,5 @@
>  #include "pthread_impl.h"
>  
> -const size_t __pthread_tsd_size = sizeof(void *) * PTHREAD_KEYS_MAX;
> -void *__pthread_tsd_main[PTHREAD_KEYS_MAX] = { 0 };
> -
>  static void (*keys[PTHREAD_KEYS_MAX])(void *);


__pthread_tsd_size was used in pthread_attr_setstack, so
we guarantee that the thread has at least that much stack
but recently the policy was changed around tls see

git log --patch src/thread/pthread_attr_setstack.c


so yes __pthread_tsd_size is not used anymore


      reply	other threads:[~2013-02-11 10:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11  9:19 Jens Gustedt
2013-02-11 10:24 ` Szabolcs Nagy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130211102415.GZ6181@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).