mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: [PATCH 2/3] Have different definitions of __pthread_tsd_main agree in size
Date: Mon, 11 Feb 2013 12:22:37 +0100	[thread overview]
Message-ID: <20130211112237.GB6181@port70.net> (raw)
In-Reply-To: <1360568420.23424.521.camel@eris.loria.fr>

* Jens Gustedt <jens.gustedt@inria.fr> [2013-02-11 08:40:20 +0100]:
> Am Sonntag, den 10.02.2013, 19:31 -0500 schrieb Rich Felker:
> > Nope, that defeats the whole purpose, which is to avoid wasting space
> > when it's not needed. This warning is bogus. There's no reason a weak
> > symbol can't have different size than a strong one that optionally
> > replaces it.
> 
> Hm, about wasting space I am not very convinced, but maybe I didn't
> understand well enough why you need all these aliases after all, and
> why you can't refer to the real symbol directly.
> 

aliases are there for a reason

> In any case, this is perhaps better done with the tool chain. I have
> good experience by having
> 
>   -fdata-sections -ffunction-sections
> 
> for the compiler options and then
> 
>    -Wl, --gc-sections
> 
> for the link. In the case of musl, this removes exactly all the dummy
> sections :) plus two others (pad and sccp), see below.
> 

are you sure about the correctness of these?

they seem to be broken to me: weak aliases are not respected
and functions are dropped even if there are weak references to
them which is bad..

eg if sccp is dropped then in any code that does not
use pthread, the cancellable syscalls will be broken
(if i understand these right)


  reply	other threads:[~2013-02-11 11:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-10 22:32 Jens Gustedt
2013-02-11  0:31 ` Rich Felker
2013-02-11  7:40   ` Jens Gustedt
2013-02-11 11:22     ` Szabolcs Nagy [this message]
2013-02-11 12:08       ` Szabolcs Nagy
2013-02-11 12:51         ` Jens Gustedt
2013-02-11 13:09           ` Szabolcs Nagy
2013-02-11 13:38             ` Jens Gustedt
2013-02-11 13:44               ` Rich Felker
2013-02-11 14:07                 ` Jens Gustedt
2013-02-11 14:39                   ` Szabolcs Nagy
2013-02-11 16:30                     ` Jens Gustedt
2013-02-11 17:08                       ` Szabolcs Nagy
2013-02-11 17:21                         ` Jens Gustedt
2013-02-11 21:49                           ` Rich Felker
2013-02-11 21:47                   ` Rich Felker
2013-02-11 21:50                     ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130211112237.GB6181@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).