From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/2786 Path: news.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 2/3] Have different definitions of __pthread_tsd_main agree in size Date: Mon, 11 Feb 2013 18:08:39 +0100 Message-ID: <20130211170839.GG6181@port70.net> References: <1360568420.23424.521.camel@eris.loria.fr> <20130211112237.GB6181@port70.net> <20130211120816.GC6181@port70.net> <1360587084.9132.83.camel@eris.loria.fr> <20130211130906.GE6181@port70.net> <1360589888.9132.104.camel@eris.loria.fr> <20130211134454.GR20323@brightrain.aerifal.cx> <1360591648.9132.117.camel@eris.loria.fr> <20130211143944.GF6181@port70.net> <1360600223.9132.185.camel@eris.loria.fr> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1360602530 17884 80.91.229.3 (11 Feb 2013 17:08:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Feb 2013 17:08:50 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-2787-gllmg-musl=m.gmane.org@lists.openwall.com Mon Feb 11 18:09:12 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1U4wsQ-0005na-8b for gllmg-musl@plane.gmane.org; Mon, 11 Feb 2013 18:09:10 +0100 Original-Received: (qmail 32744 invoked by uid 550); 11 Feb 2013 17:08:50 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 32736 invoked from network); 11 Feb 2013 17:08:50 -0000 Content-Disposition: inline In-Reply-To: <1360600223.9132.185.camel@eris.loria.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:2786 Archived-At: * Jens Gustedt [2013-02-11 17:30:23 +0100]: > Am Montag, den 11.02.2013, 15:39 +0100 schrieb Szabolcs Nagy: > > * Jens Gustedt [2013-02-11 15:07:28 +0100]: > > > So it would at least be good that the internal use of it in musl would > > > be consistent and the C library would not see two distinct objects. > > > > > > > no > > I take it that this "no" is only for the second part of the > assertion, and that you would subscribe to the shortend phrase > > So it would at least be good that the internal use of it in musl > would be consistent. > > If it is stated in POSIX that a userspace environ is a different > object from the one in the library, I am perfectly fine with > that. Documented behavior is a good thing, and userspace should see > its environ. > > As it is currently, without my patch, execv would see __environ and > execvp would see the user space environ. I am still convinced that > this isn't desirable, both should see __environ, and that is what I > meant with my subphrase "and the C library would not see two distinct > objects". > you are right execv and execvp should consistently use __environ it seems execvp was changed to fix a bug in posix_spawn but that's no longer relevant with the new implementation " fix parent-memory-clobber in posix_spawn (environ)" btw system uses environ but internal/libc.h defines environ to be __environ, i think that's hideous