mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: Fix for fields in utmp
Date: Wed, 20 Feb 2013 19:56:35 -0500	[thread overview]
Message-ID: <20130221005634.GM20323@brightrain.aerifal.cx> (raw)
In-Reply-To: <20130220184937.GU6181@port70.net>

On Wed, Feb 20, 2013 at 07:49:37PM +0100, Szabolcs Nagy wrote:
> * Chris Spiegel <cspiegel@gmail.com> [2013-02-20 10:23:09 -0800]:
> > The utmp.h header defines a few macros to access __ut_exit in the utmpx
> > struct; however, the underscores were removed in utmpx, so the macros
> > now point to non-existent struct members.  Attached is a simple patch
> > which removes them.
> 
> note that the current code is not compatible with glibc
> 
> http://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/gnu/bits/utmpx.h
> vs
> http://git.musl-libc.org/cgit/musl/tree/include/utmpx.h
> 
> it seems the __ prefix depends on _GNU_SOURCE

The versions with the __ prefix are never intended to be accessed by
name; they're just there to get the padding right. If some programs do
use them, however, we might need to provide them... BTW this is all
stub code; musl does not use utmp.

> and the 64bit abi is different on musl
> (see ut_session and ut_tv)

That should be fixed. Since it's all stubs, I don't think ABI is a big
issue here.

Rich


  reply	other threads:[~2013-02-21  0:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-20 18:23 Chris Spiegel
2013-02-20 18:49 ` Szabolcs Nagy
2013-02-21  0:56   ` Rich Felker [this message]
2013-02-26  6:49     ` Rich Felker
2013-02-26  9:22       ` Szabolcs Nagy
2013-02-26 10:34         ` Ivan Kanakarakis
2013-02-26 20:21           ` Szabolcs Nagy
2013-02-26 23:33             ` Rich Felker
2013-03-02 23:29               ` Szabolcs Nagy
2013-03-04 22:06                 ` Rich Felker
2013-04-12 11:23                   ` Ivan Kanakarakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130221005634.GM20323@brightrain.aerifal.cx \
    --to=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).