From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: strcasestr.c
Date: Wed, 20 Feb 2013 20:34:17 -0500 [thread overview]
Message-ID: <20130221013417.GO20323@brightrain.aerifal.cx> (raw)
In-Reply-To: <20130221013054.GA90956@intma.in>
On Wed, Feb 20, 2013 at 08:30:54PM -0500, Kurt H Maier wrote:
> On Wed, Feb 20, 2013 at 08:03:28PM -0500, Rich Felker wrote:
> >
> > The other somewhat reasonable option would be removing the function,
> > which would expose breakage in programs that were already using the
> > broken version in musl. I'm mildly against this, but I'd be interested
> > in hearing arguments either way.
>
> Please remove it. It's not world-ending to ask people to relink;
> programs known to require the broken functionality can run against an
> older version of musl until they're repaired. If you start enshrining
> mistakes now you're just driving down glibc avenue. I'd rather have
> musl be a correct libc than a quirky libc.
Well the other issue is using glibc-linked binaries/libs. If any of
them reference strcasestr (which they might in all those gnulib
packages mentioned earlier in this thread once gnulib detects that
glibc has its own strcasestr...), then we'd potentially want to
provide strcasestr to be able to use them..
I don't think "enshrining mistakes" is a good policy in itself, but if
they can be fixed (unbreaking the function) in ways that have other
practical benefits, that might be a better alternative.
With that said, opinion #1 noted. :)
Rich
next prev parent reply other threads:[~2013-02-21 1:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 14:59 strcasestr.c Todd C. Miller
2013-02-14 15:23 ` strcasestr.c Rich Felker
2013-02-17 19:04 ` strcasestr.c Rich Felker
2013-02-20 22:28 ` strcasestr.c John Spencer
2013-02-20 23:56 ` strcasestr.c Szabolcs Nagy
2013-02-21 1:03 ` strcasestr.c Rich Felker
2013-02-21 1:30 ` strcasestr.c Kurt H Maier
2013-02-21 1:34 ` Rich Felker [this message]
2013-02-21 6:18 ` strcasestr.c Isaac Dunham
2013-02-21 20:00 ` strcasestr.c John Spencer
2013-02-21 20:13 ` strcasestr.c Szabolcs Nagy
2013-02-22 5:20 ` strcasestr.c Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130221013417.GO20323@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).