From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: strverscmp
Date: Tue, 26 Feb 2013 01:40:15 -0500 [thread overview]
Message-ID: <20130226064015.GB20323@brightrain.aerifal.cx> (raw)
In-Reply-To: <20130218171558.bf161621.idunham@lavabit.com>
On Mon, Feb 18, 2013 at 05:15:58PM -0800, Isaac Dunham wrote:
> On Sun, 17 Feb 2013 13:39:44 -0500
> Rich Felker <dalias@aerifal.cx> wrote:
>
> >
> > Hey, sorry it's taken me so long to get to reading and reviewing this
> > well. Here are some comments, mostly stylistic, but one's about a
> > corner-case bug. See below. With that said, the algorithm looks right
> > to me, and I think we can commit soon.
> >
> > Rich
>
> All the comments seem like improvements to me.
> Attached is a revised version.
Committed. If any further improvements need to be made they can be
done as separate commits. Actually I just found one bug which I'll
fix..
Rich
next prev parent reply other threads:[~2013-02-26 6:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 7:10 musl 0.9.9 released Rich Felker
2013-02-02 2:23 ` Isaac Dunham
2013-02-02 2:38 ` Rich Felker
2013-02-02 4:04 ` strverscmp Isaac Dunham
2013-02-17 18:39 ` strverscmp Rich Felker
2013-02-19 1:15 ` strverscmp Isaac Dunham
2013-02-26 6:40 ` Rich Felker [this message]
2013-02-02 5:14 ` fgetgrent Isaac Dunham
2013-02-02 5:32 ` fgetgrent Rich Felker
2013-02-17 18:50 ` fgetgrent Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226064015.GB20323@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).