From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/2845
Path: news.gmane.org!not-for-mail
From: Rich Felker <dalias@aerifal.cx>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: strverscmp
Date: Tue, 26 Feb 2013 01:40:15 -0500
Message-ID: <20130226064015.GB20323@brightrain.aerifal.cx>
References: <20130201071053.GA14593@brightrain.aerifal.cx>
 <20130201182340.c60061b6.idunham@lavabit.com>
 <20130202023833.GW20323@brightrain.aerifal.cx>
 <20130201200452.26687bed.idunham@lavabit.com>
 <20130217183944.GF20323@brightrain.aerifal.cx>
 <20130218171558.bf161621.idunham@lavabit.com>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: ger.gmane.org 1361860827 19836 80.91.229.3 (26 Feb 2013 06:40:27 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Tue, 26 Feb 2013 06:40:27 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-2846-gllmg-musl=m.gmane.org@lists.openwall.com Tue Feb 26 07:40:49 2013
Return-path: <musl-return-2846-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@plane.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-2846-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1UAEDZ-0002ES-12
	for gllmg-musl@plane.gmane.org; Tue, 26 Feb 2013 07:40:49 +0100
Original-Received: (qmail 32496 invoked by uid 550); 26 Feb 2013 06:40:27 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 32488 invoked from network); 26 Feb 2013 06:40:27 -0000
Content-Disposition: inline
In-Reply-To: <20130218171558.bf161621.idunham@lavabit.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Xref: news.gmane.org gmane.linux.lib.musl.general:2845
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/2845>

On Mon, Feb 18, 2013 at 05:15:58PM -0800, Isaac Dunham wrote:
> On Sun, 17 Feb 2013 13:39:44 -0500
> Rich Felker <dalias@aerifal.cx> wrote:
> 
> > 
> > Hey, sorry it's taken me so long to get to reading and reviewing this
> > well. Here are some comments, mostly stylistic, but one's about a
> > corner-case bug. See below. With that said, the algorithm looks right
> > to me, and I think we can commit soon.
> > 
> > Rich
> 
> All the comments seem like improvements to me.
> Attached is a revised version.

Committed. If any further improvements need to be made they can be
done as separate commits. Actually I just found one bug which I'll
fix..

Rich