mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: Weird bug in syslog
Date: Wed, 20 Mar 2013 15:02:50 -0400	[thread overview]
Message-ID: <20130320190249.GQ20323@brightrain.aerifal.cx> (raw)
In-Reply-To: <20130320124125.GL19010@port70.net>

On Wed, Mar 20, 2013 at 01:41:26PM +0100, Szabolcs Nagy wrote:
> >  	l2 = vsnprintf(buf+l, sizeof buf - l, message, ap);
> >  	if (l2 >= 0) {
> >  		l += l2;
> 
> these are int values
> maybe we should care about overflow
> (eg making l size_t works)

Not needed. snprintf returns int. But it *can* fail: EOVERFLOW.

Rich


  parent reply	other threads:[~2013-03-20 19:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 19:32 William Haddon
2013-03-20 12:41 ` Szabolcs Nagy
2013-03-20 18:55   ` Szabolcs Nagy
2013-03-20 19:02   ` Rich Felker [this message]
2013-03-21  1:43   ` William Haddon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130320190249.GQ20323@brightrain.aerifal.cx \
    --to=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).