From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: Further bugs in syslog()
Date: Fri, 22 Mar 2013 23:53:51 -0400 [thread overview]
Message-ID: <20130323035351.GT20323@brightrain.aerifal.cx> (raw)
In-Reply-To: <20130323034538.GS20323@brightrain.aerifal.cx>
On Fri, Mar 22, 2013 at 11:45:39PM -0400, Rich Felker wrote:
> Hi all,
>
> William Haddon's report about syslog prompted me to review the file,
> and there seem to be several additional bugs:
>
> 1. log_ident stores the actual pointer passed by the caller rather
> than a copy of the string. This probably works in practice for most
> callers but it's definitely not correct.
It should be noted that, per glibc's documentation of openlog, it
shares this bug. POSIX has no text that allows such an implementation,
but I suspect all historic implementations have this bad behavior, so
it's possibly an issue that should be raised on the Austin Group
tracker...
glibc also documents closelog as clearing log_ident to the default
value. This behavior does not seem to be permitted (much less
required) by the standard.
Rich
next prev parent reply other threads:[~2013-03-23 3:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 3:45 Rich Felker
2013-03-23 3:53 ` Rich Felker [this message]
2013-03-23 4:05 ` Proposed syslog patch [Re: [musl] Further bugs in syslog()] Rich Felker
2013-03-23 16:17 ` Szabolcs Nagy
2013-03-23 21:27 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130323035351.GT20323@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).