From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: patch: make the size of errbuf configurable
Date: Sun, 19 May 2013 18:09:42 -0400 [thread overview]
Message-ID: <20130519220941.GJ20323@brightrain.aerifal.cx> (raw)
In-Reply-To: <51994949.1060305@eservices.virginia.edu>
On Sun, May 19, 2013 at 05:51:05PM -0400, Z. Gilboa wrote:
> >My preference is that either long pathnames should be truncated in a
> >reasonable way (keep in mind that the message is *not* parsable by the
> >caller; the only way it can be used is presenting it to the user)
> certainly; the initial motivation was log-file processing.
>
> >or
> >larger buffers should be dynamically allocated. The only reason I did
> >not go the dynamic-allocation path to begin with was to make it so
> >non-thread-safe usage of dlerror yields (at worst) corrupted messages
> >rather than crashes. This can also be achieved with dynamic allocation
> >(as long as the old too-short buffer is never freed), but it's more
> >complex.
>
> In my understanding, the current approach of having a fixed buffer
> size is by far the superior one.
Could you elaborate as to why? Are you concerned about memory usage?
Code complexity? Or some other reason?
Rich
next prev parent reply other threads:[~2013-05-19 22:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-19 20:12 Z. Gilboa
2013-05-19 21:03 ` Rich Felker
2013-05-19 21:51 ` Z. Gilboa
2013-05-19 22:09 ` Rich Felker [this message]
2013-05-19 22:26 ` Z. Gilboa
2013-05-19 23:22 ` Rich Felker
2013-05-20 0:09 ` Z. Gilboa
2013-05-20 0:21 ` Rich Felker
2013-05-20 0:37 ` Z. Gilboa
2013-05-19 21:05 ` Szabolcs Nagy
2013-05-19 21:36 ` Luca Barbato
2013-05-19 21:48 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130519220941.GJ20323@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).