From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: Fix for tcsh
Date: Fri, 21 Jun 2013 16:16:54 -0400 [thread overview]
Message-ID: <20130621201653.GG29800@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAKHv7pi5eMVEZaNiK3s4wEcp7hm=7y9Z6EjU91m966XazJ2KmA@mail.gmail.com>
On Fri, Jun 21, 2013 at 10:00:56PM +0200, Paul Schutte wrote:
> Thanks Rich.
>
> I thought that BSDWAIT was defined in one of the standard headers.
If that were the case, you never would have had any problems, since
musl does not define it.
> You are right about where BSDWAIT is defined, but now I am back to how
> should I write the "ifdef" ?
>
> I could use* !(defined(__ANDROID__) || (defined(__linux__)&&
> !defined(__GLIBC__)))* in the place of "if !defined(__ANDROID__)", but
> then things might go wrong for uclibc and other libcs.
>
> If I understand you correctly, all new implementations should use int
> instead of union, so above ifdef should be a workable solution.
>
> #if defined(_BSD) || (defined(IRIS4D) && __STDC__) || defined(__lucid) ||
> defined(__linux__) || defined(__GNU__) || defined(__GLIBC__)
> *# if !defined(__ANDROID__)*
> # define BSDWAIT
> # endif
> #endif /* _BSD || (IRIS4D && __STDC__) || __lucid || glibc */
It should be simply:
#if defined(_BSD) || (defined(IRIS4D) && __STDC__) || #defined(__lucid)
BSDWAIT (union wait instead of int) is available as a legacy
compatibility interface on glibc, but it's not desirable to use it,
much less necessary. Fixing this would eliminate the need for a
special-case excluding android, too.
Rich
next prev parent reply other threads:[~2013-06-21 20:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 9:19 Paul Schutte
2013-06-21 9:27 ` Igmar Palsenberg
2013-06-21 15:52 ` Rich Felker
2013-06-21 20:00 ` Paul Schutte
2013-06-21 20:16 ` Rich Felker [this message]
2013-06-21 20:26 ` Paul Schutte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130621201653.GG29800@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).