From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: Use of size_t and ssize_t in mseek
Date: Thu, 4 Jul 2013 13:10:54 +0200 [thread overview]
Message-ID: <20130704111054.GY15323@port70.net> (raw)
In-Reply-To: <20130704081245.GN29800@brightrain.aerifal.cx>
* Rich Felker <dalias@aerifal.cx> [2013-07-04 04:12:45 -0400]:
> On Thu, Jul 04, 2013 at 09:11:29AM +0200, Jens Gustedt wrote:
> > > qsort_s can store the comparison function and context in TLS, and then
> > > pass to qsort a comparison function that grabs these from TLS and
> > > calls the original comparison function with the context pointer. This
> > > is valid assuming qsort does not run the comparisons in new threads.
> >
> > sure, but for an execution of qsort_s this would have a lot of
> > indirections and a call to TLS for every comparison. For performance
> > sensible functions like this, this doesn't sound very attractive.
>
> If it's inside musl, the TLS dereference is very cheap on most archs:
> it's just a constant offset from the thread pointer. Same if the code
> were static linked in the main program. Otherwise, if it's a dynamic
> library, then yes it would be fairly costly, like you say.
it seems to me that if a qsort_s call sets the tls and then before
the callee reads that pointer a signal interrupts with a handler that
calls qsort_s again then the tls is overwritten by another pointer
so you lose signal-safety with the tls design
> > (In P99 I do that with inlining and gcc shows to be able to expand all
> > comparisons in place and to optimize that smoothly.)
>
> Nice. I'll have to take a look -- I've always wanted to see a fully
> inlined qsort that could be compared to the C++ template-based sorts
> to demonstrate that inline functions in C can do just as good or
> better, inlining the comparison callback... :)
* Jens Gustedt <jens.gustedt@inria.fr> [2013-07-04 10:45:47 +0200]:
> http://gustedt.wordpress.com/2012/12/04/inline-functions-as-good-as-templates/
good to know that this works now..
it's not clear from the article how the compiler knew that the
last arg for qsort_s is supposed to be passed to the comparision
function: was it lto+static linking or was the internal of
qsort_s visible in the same translation unit?
a few years ago i did similar experiments but those failed back then:
https://groups.google.com/d/msg/comp.lang.c/sO2oYdZGdd8/bqFZ4i81P7AJ
(P.S. google seems to broke its usenet archives, if anyone
knows a good one that works without javascript enabled i'm
interested, meanwhile you can just replace /d/ with /forum/print/
in the url and get a reasonable rendering without js)
next prev parent reply other threads:[~2013-07-04 11:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 3:52 Matthew Fernandez
2013-06-27 4:10 ` Rich Felker
2013-06-27 4:16 ` Matthew Fernandez
2013-06-27 4:23 ` Rich Felker
2013-06-27 4:31 ` Matthew Fernandez
2013-06-27 15:34 ` Rich Felker
2013-06-28 0:49 ` Matthew Fernandez
2013-06-28 1:22 ` Rich Felker
2013-06-28 1:34 ` Matthew Fernandez
2013-06-28 1:48 ` Rich Felker
2013-06-28 1:56 ` Matthew Fernandez
2013-06-29 4:13 ` Rich Felker
2013-06-29 13:38 ` Matthew Fernandez
2013-06-29 14:17 ` Rich Felker
2013-06-29 14:56 ` Jens Gustedt
2013-06-29 15:48 ` Rich Felker
2013-06-29 16:01 ` Jens Gustedt
2013-06-29 16:13 ` Rich Felker
2013-06-29 16:39 ` Jens Gustedt
2013-07-04 1:28 ` Rich Felker
2013-07-04 6:11 ` Jens Gustedt
2013-07-04 6:37 ` Rich Felker
2013-07-04 7:11 ` Jens Gustedt
2013-07-04 8:12 ` Rich Felker
2013-07-04 8:45 ` Jens Gustedt
2013-07-04 15:24 ` Rich Felker
2013-07-04 11:10 ` Szabolcs Nagy [this message]
2013-07-04 11:58 ` Jens Gustedt
2013-07-04 15:26 ` Rich Felker
2013-06-27 10:35 ` Szabolcs Nagy
2013-06-27 15:05 ` Rich Felker
2013-06-27 16:47 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130704111054.GY15323@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).