mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: time code progress
Date: Wed, 17 Jul 2013 13:39:06 +0200	[thread overview]
Message-ID: <20130717113906.GT15323@port70.net> (raw)
In-Reply-To: <20130717093325.GA12469@brightrain.aerifal.cx>

* Rich Felker <dalias@aerifal.cx> [2013-07-17 05:33:25 -0400]:
> Committed. Please let me know what bugs you find. :-)
> 

gcc found this:

diff --git a/src/time/__map_file.c b/src/time/__map_file.c
index b6bf272..b322f09 100644
--- a/src/time/__map_file.c
+++ b/src/time/__map_file.c
@@ -14,7 +14,7 @@ const char unsigned *__map_file(const char *pathname, size_t *size)
        if (fd < 0) return 0;
        if (!__syscall(SYS_fstat, fd, &st))
                map = __mmap(0, st.st_size, PROT_READ, MAP_SHARED, fd, 0);
-       __syscall(SYS_close);
+       __syscall(SYS_close, fd);
        *size = st.st_size;
        return map == MAP_FAILED ? 0 : map;
 }


(i think it did not like the syscall arg counting in case of 0 args in
#define __SYSCALL_NARGS_X(a,b,c,d,e,f,g,h,n,...) n
#define __SYSCALL_NARGS(...) __SYSCALL_NARGS_X(__VA_ARGS__,7,6,5,4,3,2,1,0)
)


  reply	other threads:[~2013-07-17 11:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16 19:45 Rich Felker
2013-07-17  9:33 ` Rich Felker
2013-07-17 11:39   ` Szabolcs Nagy [this message]
2013-07-17 12:09     ` Jens Gustedt
2013-07-17 13:19       ` Szabolcs Nagy
2013-07-17 13:39         ` Jens Gustedt
2013-07-17 14:36           ` Rich Felker
2013-07-17 13:31     ` Rich Felker
2013-07-17 14:27       ` Szabolcs Nagy
2013-07-20  1:11   ` Szabolcs Nagy
2013-07-20  1:22     ` Rich Felker
2013-07-20  1:29       ` Szabolcs Nagy
2013-07-20  1:35         ` Rich Felker
2013-07-22 21:38 ` Rob Landley
2013-07-22 21:46   ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130717113906.GT15323@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).