From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: time code progress
Date: Wed, 17 Jul 2013 16:27:38 +0200 [thread overview]
Message-ID: <20130717142737.GV15323@port70.net> (raw)
In-Reply-To: <20130717133110.GB12469@brightrain.aerifal.cx>
* Rich Felker <dalias@aerifal.cx> [2013-07-17 09:31:10 -0400]:
> I'm glad to hear this is the worst bug found so far. :-)
>
here is another one:
posix seems to require EOVERFLOW when the result cannot be represented
(i cleaned up my mktime/gmtime test copied from libc-testsuit)
diff --git a/src/time/mktime.c b/src/time/mktime.c
index e38b461..ef1fb42 100644
--- a/src/time/mktime.c
+++ b/src/time/mktime.c
@@ -25,6 +25,6 @@ time_t mktime(struct tm *tm)
return t;
error:
- errno = EINVAL;
+ errno = EOVERFLOW;
return -1;
}
next prev parent reply other threads:[~2013-07-17 14:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 19:45 Rich Felker
2013-07-17 9:33 ` Rich Felker
2013-07-17 11:39 ` Szabolcs Nagy
2013-07-17 12:09 ` Jens Gustedt
2013-07-17 13:19 ` Szabolcs Nagy
2013-07-17 13:39 ` Jens Gustedt
2013-07-17 14:36 ` Rich Felker
2013-07-17 13:31 ` Rich Felker
2013-07-17 14:27 ` Szabolcs Nagy [this message]
2013-07-20 1:11 ` Szabolcs Nagy
2013-07-20 1:22 ` Rich Felker
2013-07-20 1:29 ` Szabolcs Nagy
2013-07-20 1:35 ` Rich Felker
2013-07-22 21:38 ` Rob Landley
2013-07-22 21:46 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130717142737.GV15323@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).