From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: time code progress
Date: Wed, 17 Jul 2013 10:36:33 -0400 [thread overview]
Message-ID: <20130717143633.GD12469@brightrain.aerifal.cx> (raw)
In-Reply-To: <1374068375.20259.255.camel@eris.loria.fr>
On Wed, Jul 17, 2013 at 03:39:35PM +0200, Jens Gustedt wrote:
> Am Mittwoch, den 17.07.2013, 15:19 +0200 schrieb Szabolcs Nagy:
> > note that the problem is not that __VA_ARGS__ is empty
> > (it's not, contrary to what i might implied), but that
> > if n becomes 0 (== __VA_ARGS__ expands to one argument),
> > then there is no more arguments in the __SYSCALL_NARGS_X
> > call to substitute for '...', so a simple fix would be
> >
> > #define __SYSCALL_NARGS(...) __SYSCALL_NARGS_X(__VA_ARGS__,7,6,5,4,3,2,1,0, tralala)
>
> right, you always have the name of the syscall as first argument
>
> > but i'm not sure if this should be fixed (this is internal
> > code and i think there are no 0 argument syscalls)
> >
> > i just wanted to record how i found the close without fd issue
> > (which shows that some kind of type checking for syscall
> > arguments would help libc hacking.. but that's non-trivial
> > to do)
>
> if there are really no 0 argument syscalls
>
> #define __SYSCALL_NARGS(...) __SYSCALL_NARGS_X(__VA_ARGS__,7,6,5,4,3,2,1, tralali, tralala)
There are, e.g. getpid. So I'm not sure why this issue has never come
up before. I'm guessing you have a newer gcc that added a new warning
for it; my gcc does not seem to warn.
Anyway, I thought of the 0-arg issue back when I came up with these
macros, and it was resolved by always having the syscall number. But I
failed to realize there would be no arguments for the ... slot of
__SYSCALL_NARGS_X.
> implement. I could imagine how to check for the number of arguments of
> particular syscalls. Type checking would be more difficult, and would
> probably need some maintenance.
This might be more easily achieved with a grep recipe...
Rich
next prev parent reply other threads:[~2013-07-17 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 19:45 Rich Felker
2013-07-17 9:33 ` Rich Felker
2013-07-17 11:39 ` Szabolcs Nagy
2013-07-17 12:09 ` Jens Gustedt
2013-07-17 13:19 ` Szabolcs Nagy
2013-07-17 13:39 ` Jens Gustedt
2013-07-17 14:36 ` Rich Felker [this message]
2013-07-17 13:31 ` Rich Felker
2013-07-17 14:27 ` Szabolcs Nagy
2013-07-20 1:11 ` Szabolcs Nagy
2013-07-20 1:22 ` Rich Felker
2013-07-20 1:29 ` Szabolcs Nagy
2013-07-20 1:35 ` Rich Felker
2013-07-22 21:38 ` Rob Landley
2013-07-22 21:46 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130717143633.GD12469@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).