From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: time code progress
Date: Sat, 20 Jul 2013 03:11:06 +0200 [thread overview]
Message-ID: <20130720011106.GC15323@port70.net> (raw)
In-Reply-To: <20130717093325.GA12469@brightrain.aerifal.cx>
* Rich Felker <dalias@aerifal.cx> [2013-07-17 05:33:25 -0400]:
> Committed. Please let me know what bugs you find. :-)
in mktime the overflow check is not strictly ok,
time_t is signed so the check relies on signed overflow
long long t = __tm_to_secs(tm);
// ...
if ((time_t)t != t) goto error;
i'm not sure how to do the check efficiently without
invoking ub, but at least this should be commented
time_t seem to be long on all supported platforms so this should work:
if (t>LONG_MAX || t<LONG_MIN) goto error;
next prev parent reply other threads:[~2013-07-20 1:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 19:45 Rich Felker
2013-07-17 9:33 ` Rich Felker
2013-07-17 11:39 ` Szabolcs Nagy
2013-07-17 12:09 ` Jens Gustedt
2013-07-17 13:19 ` Szabolcs Nagy
2013-07-17 13:39 ` Jens Gustedt
2013-07-17 14:36 ` Rich Felker
2013-07-17 13:31 ` Rich Felker
2013-07-17 14:27 ` Szabolcs Nagy
2013-07-20 1:11 ` Szabolcs Nagy [this message]
2013-07-20 1:22 ` Rich Felker
2013-07-20 1:29 ` Szabolcs Nagy
2013-07-20 1:35 ` Rich Felker
2013-07-22 21:38 ` Rob Landley
2013-07-22 21:46 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130720011106.GC15323@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).