From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/3734 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] inet_ntop() and ipv4 address Date: Thu, 25 Jul 2013 02:54:33 -0400 Message-ID: <20130725065432.GD4284@brightrain.aerifal.cx> References: <20130725122127.4dcbf8de@sibserver.ru> <20130725055913.GC4284@brightrain.aerifal.cx> <20130725144212.09f9933a@sibserver.ru> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1374735287 6713 80.91.229.3 (25 Jul 2013 06:54:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 25 Jul 2013 06:54:47 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-3738-gllmg-musl=m.gmane.org@lists.openwall.com Thu Jul 25 08:54:50 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1V2FRm-0004g9-RO for gllmg-musl@plane.gmane.org; Thu, 25 Jul 2013 08:54:46 +0200 Original-Received: (qmail 5387 invoked by uid 550); 25 Jul 2013 06:54:45 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 5379 invoked from network); 25 Jul 2013 06:54:45 -0000 Content-Disposition: inline In-Reply-To: <20130725144212.09f9933a@sibserver.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:3734 Archived-At: On Thu, Jul 25, 2013 at 02:42:12PM +0800, orc wrote: > On Thu, 25 Jul 2013 01:59:13 -0400 > Rich Felker wrote: > > > On Thu, Jul 25, 2013 at 12:21:27PM +0800, orc wrote: > > > inet_ntop() does not embed plain ipv4 address at end (like > > > "::ffff:10.0.0.1"). This patch fixes it, but it is a bit ugly. > > > Without it is a bit harder to read logs of some daemons that > > > support only one address family socket binding and seeing output of > > > 'ss -tn'. Adopt if needed. > > > > As I understand it, the "IPv4 compatible" addresses (::a.b.c.d) are > > deprecated and have never actually been used in deployed IPv6. Only > > the v4-mapped form (::ffff:a.b.c.d) is used/usable. For the most part, > > supporting the useless form seems harmless, but there is one harmful > > case: it looks like your code will wrongly convert :: to ::0.0.0.0 > > instead of plain ::. Is it worth trying to keep the "v4 compatible" > > form supported and just special-casing ::, or should we just drop it? > > I think it's still worth supporting ::ffff:a.b.c.d form, just quote > from my vsftpd logs: Oh I agree the ::ffff:a.b.c.d form is worth supporting. I was asking if there's any need to also support the ::a.b.c.d form, which would require a special workaround for ::. Rich