From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/3733
Path: news.gmane.org!not-for-mail
From: orc <orc@sibserver.ru>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: [PATCH] inet_ntop() and ipv4 address
Date: Thu, 25 Jul 2013 14:42:12 +0800
Message-ID: <20130725144212.09f9933a@sibserver.ru>
References: <20130725122127.4dcbf8de@sibserver.ru>
	<20130725055913.GC4284@brightrain.aerifal.cx>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Trace: ger.gmane.org 1374734116 27291 80.91.229.3 (25 Jul 2013 06:35:16 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Thu, 25 Jul 2013 06:35:16 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-3737-gllmg-musl=m.gmane.org@lists.openwall.com Thu Jul 25 08:35:19 2013
Return-path: <musl-return-3737-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@plane.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-3737-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1V2F8v-0003Zc-KX
	for gllmg-musl@plane.gmane.org; Thu, 25 Jul 2013 08:35:17 +0200
Original-Received: (qmail 26445 invoked by uid 550); 25 Jul 2013 06:35:17 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 26437 invoked from network); 25 Jul 2013 06:35:16 -0000
In-Reply-To: <20130725055913.GC4284@brightrain.aerifal.cx>
X-Mailer: claws-mail
Xref: news.gmane.org gmane.linux.lib.musl.general:3733
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/3733>

On Thu, 25 Jul 2013 01:59:13 -0400
Rich Felker <dalias@aerifal.cx> wrote:

> On Thu, Jul 25, 2013 at 12:21:27PM +0800, orc wrote:
> > inet_ntop() does not embed plain ipv4 address at end (like
> > "::ffff:10.0.0.1"). This patch fixes it, but it is a bit ugly.
> > Without it is a bit harder to read logs of some daemons that
> > support only one address family socket binding and seeing output of
> > 'ss -tn'. Adopt if needed.
> 
> As I understand it, the "IPv4 compatible" addresses (::a.b.c.d) are
> deprecated and have never actually been used in deployed IPv6. Only
> the v4-mapped form (::ffff:a.b.c.d) is used/usable. For the most part,
> supporting the useless form seems harmless, but there is one harmful
> case: it looks like your code will wrongly convert :: to ::0.0.0.0
> instead of plain ::. Is it worth trying to keep the "v4 compatible"
> form supported and just special-casing ::, or should we just drop it?
> 
> Rich

I think it's still worth supporting ::ffff:a.b.c.d form, just quote
from my vsftpd logs:
CONNECT: Client "::ffff:a00:203" # (for 10.0.2.3)
Same output of 'ss -tn' when someone connected to IPv6-only listening
socket. IPv4 compatible addresses I taken from glibc.
Wrong convert: see my next message. It was my fault.