From: orc <orc@sibserver.ru>
To: musl@lists.openwall.com
Subject: Re: [PATCH] inet_ntop() and ipv4 address
Date: Thu, 25 Jul 2013 15:09:10 +0800 [thread overview]
Message-ID: <20130725150910.35c012e0@sibserver.ru> (raw)
In-Reply-To: <20130725065432.GD4284@brightrain.aerifal.cx>
On Thu, 25 Jul 2013 02:54:33 -0400
Rich Felker <dalias@aerifal.cx> wrote:
> On Thu, Jul 25, 2013 at 02:42:12PM +0800, orc wrote:
> > On Thu, 25 Jul 2013 01:59:13 -0400
> > Rich Felker <dalias@aerifal.cx> wrote:
> >
> > > On Thu, Jul 25, 2013 at 12:21:27PM +0800, orc wrote:
> > > > inet_ntop() does not embed plain ipv4 address at end (like
> > > > "::ffff:10.0.0.1"). This patch fixes it, but it is a bit ugly.
> > > > Without it is a bit harder to read logs of some daemons that
> > > > support only one address family socket binding and seeing
> > > > output of 'ss -tn'. Adopt if needed.
> > >
> > > As I understand it, the "IPv4 compatible" addresses (::a.b.c.d)
> > > are deprecated and have never actually been used in deployed
> > > IPv6. Only the v4-mapped form (::ffff:a.b.c.d) is used/usable.
> > > For the most part, supporting the useless form seems harmless,
> > > but there is one harmful case: it looks like your code will
> > > wrongly convert :: to ::0.0.0.0 instead of plain ::. Is it worth
> > > trying to keep the "v4 compatible" form supported and just
> > > special-casing ::, or should we just drop it?
> >
> > I think it's still worth supporting ::ffff:a.b.c.d form, just quote
> > from my vsftpd logs:
>
> Oh I agree the ::ffff:a.b.c.d form is worth supporting. I was asking
> if there's any need to also support the ::a.b.c.d form, which would
> require a special workaround for ::.
>
> Rich
If it needs hacks that don't worth implementing, then no. Can't
remember where I seen ::a.b.c.d last time.
next prev parent reply other threads:[~2013-07-25 7:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 4:21 orc
2013-07-25 4:36 ` orc
2013-07-25 5:59 ` Rich Felker
2013-07-25 6:42 ` orc
2013-07-25 6:54 ` Rich Felker
2013-07-25 7:09 ` orc [this message]
2013-07-25 7:42 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725150910.35c012e0@sibserver.ru \
--to=orc@sibserver.ru \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).