From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/3873 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Conformance issues to address after 0.9.12 release Date: Mon, 12 Aug 2013 23:32:32 -0400 Message-ID: <20130813033231.GB221@brightrain.aerifal.cx> References: <20130729063456.GA31564@brightrain.aerifal.cx> <20130729160046.GC25714@port70.net> <20130729210448.GG4284@brightrain.aerifal.cx> <20130730022621.GF25714@port70.net> <20130812192704.GE5368@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1376364764 24599 80.91.229.3 (13 Aug 2013 03:32:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Aug 2013 03:32:44 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-3877-gllmg-musl=m.gmane.org@lists.openwall.com Tue Aug 13 05:32:47 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1V95Li-0008R7-II for gllmg-musl@plane.gmane.org; Tue, 13 Aug 2013 05:32:46 +0200 Original-Received: (qmail 17759 invoked by uid 550); 13 Aug 2013 03:32:45 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 17751 invoked from network); 13 Aug 2013 03:32:45 -0000 Content-Disposition: inline In-Reply-To: <20130812192704.GE5368@port70.net> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:3873 Archived-At: On Mon, Aug 12, 2013 at 09:27:04PM +0200, Szabolcs Nagy wrote: > diff --git a/src/math/i386/asin.s b/src/math/i386/asin.s > index 932c754..7e49409 100644 > --- a/src/math/i386/asin.s > +++ b/src/math/i386/asin.s > @@ -2,7 +2,20 @@ > .type asinf,@function > asinf: > flds 4(%esp) > - jmp 1f > + mov 4(%esp),%eax > + add %eax,%eax > + cmp $0x01000000,%eax > + jae 1f > + # subnormal x, return x with underflow > + fnstsw %ax > + and $16,%ax > + jnz 2f > + push %eax > + fld %st(0) > + fmul %st(1) > + fstps (%esp) > + pop %eax > +2: ret Why the push/pop? Is there a reason you can't just store over top of the argument slot at 4(%esp) or even below the stack pointer at -4(%esp)? The latter would be unsafe if you ever wanted to read back the value since it could be clobbered asynchronously by a signal handler, but you don't want/need to read it back anyway. Rich