From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: Build system adjustments for subarchs
Date: Wed, 14 Aug 2013 00:02:26 -0400 [thread overview]
Message-ID: <20130814040226.GL221@brightrain.aerifal.cx> (raw)
In-Reply-To: <20130814034226.GK221@brightrain.aerifal.cx>
On Tue, Aug 13, 2013 at 11:42:26PM -0400, Rich Felker wrote:
> > Actually, this would work great if I could write an abstract rule that
> > says roughly: for each .o target %.o, add dependencies on %.c and
> > $(wildcard */%.s). This would make it so files with asm always get
> > rebuilt if either the base C file or any of the asm versions, for any
> > arch or subarch, has been modified. Obviously in some cases the
> > rebuild would be spurious, but such files are sufficiently small that
> > I don't care; the simplicity of a universal rule with no
> > arch-dependent dependency data to maintain is much more valuable.
> >
> > Unfortunately, I don't know a way to do this with make, but I believe
> > there should be a way...
>
> This seems to do it, though maybe there's a more elegant way:
>
> define archrule =
> $(dir $(patsubst %/,%,$(dir $(s))))$(notdir $(s:.s=.o)): $(s)
> endef
>
> $(foreach s,$(wildcard src/*/$(ARCH)*/*.s),$(eval $(call archrule,$(s))))
>
> [...]
>
> I'm going to run some tests on arm, and it if works, I'll commit.
I think it should be $(1) rather than $(s) in the archrule, but for
some reason, the $(eval ...) is not doing _anything_ on make 3.81 on
my Debian box. With my usual make 3.82, it works fine. This is not
really a show-stopper, since no errors occur; it just means
dependencies aren't getting honored on some versions of make that
might still be out there in the wild. But I would very much appreciate
some insight on why this is happening, from any GNU make experts...
Rich
next prev parent reply other threads:[~2013-08-14 4:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 1:06 Rich Felker
2013-08-14 1:16 ` Rich Felker
2013-08-14 1:42 ` Luca Barbato
2013-08-14 1:53 ` Rich Felker
2013-08-14 2:25 ` Rich Felker
2013-08-14 3:42 ` Rich Felker
2013-08-14 4:02 ` Rich Felker [this message]
2013-08-14 15:09 ` Szabolcs Nagy
2013-08-14 15:15 ` Rich Felker
2013-08-14 15:28 ` Luca Barbato
2013-08-15 0:55 ` Strake
2013-08-15 1:48 ` Rich Felker
2013-08-15 12:33 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814040226.GL221@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).