From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/3913 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: dn_expand() confuses postfix Date: Thu, 15 Aug 2013 02:36:47 -0400 Message-ID: <20130815063647.GV221@brightrain.aerifal.cx> References: <20130814021920.7e719d8f@sibserver.ru> <20130814220625.GT221@brightrain.aerifal.cx> <20130815141422.3bc4502c@sibserver.ru> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1376548618 15936 80.91.229.3 (15 Aug 2013 06:36:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Aug 2013 06:36:58 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-3917-gllmg-musl=m.gmane.org@lists.openwall.com Thu Aug 15 08:37:02 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1V9rB6-0001MZ-DX for gllmg-musl@plane.gmane.org; Thu, 15 Aug 2013 08:37:00 +0200 Original-Received: (qmail 7283 invoked by uid 550); 15 Aug 2013 06:36:59 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 7275 invoked from network); 15 Aug 2013 06:36:59 -0000 Content-Disposition: inline In-Reply-To: <20130815141422.3bc4502c@sibserver.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:3913 Archived-At: On Thu, Aug 15, 2013 at 02:14:22PM +0800, orc wrote: > On Wed, 14 Aug 2013 18:06:25 -0400 > Rich Felker wrote: > > > On Wed, Aug 14, 2013 at 02:19:20AM +0800, orc wrote: > > > musl's dn_expand() confuses postfix - always returns 0, then > > > postfix's libdns.a gets wrong shifts and gives up with something > > > like: > > > > > > ../test_dns_lookup: lookup yandex.ru type MX flags 2 > > > ../test_dns_lookup: dns_query: yandex.ru (MX): OK > > > ../test_dns_lookup: warning: dns_get_fixed: bad class: 30722 > > > ../test_dns_lookup: fatal: Name service error for name=yandex.ru > > > type=MX: Malformed or unexpected name server reply > > > > > > If someone will face same error with postfix & musl, then get > > > portable dn_expand.c from > > > http://tclsysdns.googlecode.com/svn/trunk/unix/dn_expand.c and put > > > it in src/dns (edit Makefile.in to include src & obj). > > > > I've committed some fixes to this code. Please let me know if the > > issue persists; I did not have test cases to check that the return > > value is right, so there's a possibility it may be off-by-one or > > something. > > Other issue now: > > ../test_dns_lookup: lookup yandex.ru type MX flags 2 > ../test_dns_lookup: dns_query: yandex.ru (MX): OK > ../test_dns_lookup: warning: valid_hostname: invalid character 6(decimal): ?yande.?r > ../test_dns_lookup: warning: malformed domain name in resource name of MX record for ?yande.?r: ?yande.?r > ../test_dns_lookup: fatal: Name service error for name=yandex.ru type=MX: Malformed or unexpected name server reply > > ../test_dns_lookup: lookup ya.ru type MX flags 2 > ../test_dns_lookup: dns_query: ya.ru (MX): OK > ../test_dns_lookup: warning: valid_hostname: invalid character 2(decimal): ?y.?r > ../test_dns_lookup: warning: malformed domain name in resource name of MX record for ?y.?r: ?y.?r > ../test_dns_lookup: fatal: Name service error for name=ya.ru type=MX: Malformed or unexpected name server reply > > temp buffer at src/dns/dns_lookup.c:287 is messed up with these. OK, I'll see if I can dump a dns packet or two to run the code on and see if the return values look wrong.. Rich