From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/3941 Path: news.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: SUN_LEN Date: Wed, 21 Aug 2013 18:34:29 +0200 Message-ID: <20130821163428.GE30088@port70.net> References: <5214AC94.9090408@barfooze.de> <5214B4CF.4090202@barfooze.de> <20130821144552.GD30088@port70.net> <20130821162339.GY20515@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1377102879 11197 80.91.229.3 (21 Aug 2013 16:34:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Aug 2013 16:34:39 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-3945-gllmg-musl=m.gmane.org@lists.openwall.com Wed Aug 21 18:34:42 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1VCBMn-00072f-CL for gllmg-musl@plane.gmane.org; Wed, 21 Aug 2013 18:34:41 +0200 Original-Received: (qmail 5442 invoked by uid 550); 21 Aug 2013 16:34:40 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 5434 invoked from network); 21 Aug 2013 16:34:40 -0000 Content-Disposition: inline In-Reply-To: <20130821162339.GY20515@brightrain.aerifal.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:3941 Archived-At: * Rich Felker [2013-08-21 12:23:39 -0400]: > > #if defined(_BSD_SOURCE) || defined(_GNU_SOURCE) > > #define SUN_LEN(s) (sizeof *(s) - sizeof (s)->sun_path + strlen((s)->sun_path)) > > #endif > > This is insufficient, since sys/un.h does not expose strlen. We could > either add a conditional declaration of strlen under this #if, or make > an inline function for SUN_LEN that just does the strlen-like loop > manually. I'm not sure what's best. declare strlen but i would not worry about this much, if you use such a macro you are already outside the well-defined zone.. and musl does not need to be nice there