From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: SUN_LEN
Date: Wed, 21 Aug 2013 12:36:45 -0400 [thread overview]
Message-ID: <20130821163645.GZ20515@brightrain.aerifal.cx> (raw)
In-Reply-To: <20130821163428.GE30088@port70.net>
On Wed, Aug 21, 2013 at 06:34:29PM +0200, Szabolcs Nagy wrote:
> * Rich Felker <dalias@aerifal.cx> [2013-08-21 12:23:39 -0400]:
> > > #if defined(_BSD_SOURCE) || defined(_GNU_SOURCE)
> > > #define SUN_LEN(s) (sizeof *(s) - sizeof (s)->sun_path + strlen((s)->sun_path))
> > > #endif
> >
> > This is insufficient, since sys/un.h does not expose strlen. We could
> > either add a conditional declaration of strlen under this #if, or make
> > an inline function for SUN_LEN that just does the strlen-like loop
> > manually. I'm not sure what's best.
>
> declare strlen
>
> but i would not worry about this much, if you use such a
> macro you are already outside the well-defined zone..
> and musl does not need to be nice there
Declaring strlen is not easy because size_t is not defined. So I guess
we also need an additional #if before including bits/alltypes.h to
define __NEED_size_t...
This is why I thought a function might be less ugly.
Rich
next prev parent reply other threads:[~2013-08-21 16:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 9:57 SUN_LEN 小林悠
2013-08-21 12:03 ` SUN_LEN John Spencer
2013-08-21 12:23 ` SUN_LEN 小林悠
2013-08-21 12:38 ` SUN_LEN John Spencer
2013-08-21 13:27 ` SUN_LEN 小林悠
2013-08-21 14:45 ` SUN_LEN Szabolcs Nagy
2013-08-21 15:25 ` SUN_LEN 小林悠
2013-08-21 16:23 ` SUN_LEN Rich Felker
2013-08-21 16:34 ` SUN_LEN Szabolcs Nagy
2013-08-21 16:36 ` Rich Felker [this message]
2013-08-21 16:42 ` SUN_LEN Rich Felker
2013-08-21 17:00 ` SUN_LEN Szabolcs Nagy
2013-08-21 17:11 ` SUN_LEN Yu Kobayashi
2013-08-21 17:25 ` SUN_LEN Rich Felker
2013-08-21 17:29 ` SUN_LEN Yu Kobayashi
2013-08-21 17:58 ` SUN_LEN Yu Kobayashi
2013-08-21 18:07 ` SUN_LEN Rich Felker
2013-08-21 17:32 ` SUN_LEN Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821163645.GZ20515@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).