From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/3943 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: SUN_LEN Date: Wed, 21 Aug 2013 12:42:20 -0400 Message-ID: <20130821164220.GA20515@brightrain.aerifal.cx> References: <5214AC94.9090408@barfooze.de> <5214B4CF.4090202@barfooze.de> <20130821144552.GD30088@port70.net> <20130821162339.GY20515@brightrain.aerifal.cx> <20130821163428.GE30088@port70.net> <20130821163645.GZ20515@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1377103352 16814 80.91.229.3 (21 Aug 2013 16:42:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Aug 2013 16:42:32 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-3947-gllmg-musl=m.gmane.org@lists.openwall.com Wed Aug 21 18:42:35 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1VCBUQ-00011q-V0 for gllmg-musl@plane.gmane.org; Wed, 21 Aug 2013 18:42:35 +0200 Original-Received: (qmail 12131 invoked by uid 550); 21 Aug 2013 16:42:34 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 12123 invoked from network); 21 Aug 2013 16:42:33 -0000 Content-Disposition: inline In-Reply-To: <20130821163645.GZ20515@brightrain.aerifal.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:3943 Archived-At: On Wed, Aug 21, 2013 at 12:36:45PM -0400, Rich Felker wrote: > On Wed, Aug 21, 2013 at 06:34:29PM +0200, Szabolcs Nagy wrote: > > * Rich Felker [2013-08-21 12:23:39 -0400]: > > > > #if defined(_BSD_SOURCE) || defined(_GNU_SOURCE) > > > > #define SUN_LEN(s) (sizeof *(s) - sizeof (s)->sun_path + strlen((s)->sun_path)) > > > > #endif > > > > > > This is insufficient, since sys/un.h does not expose strlen. We could > > > either add a conditional declaration of strlen under this #if, or make > > > an inline function for SUN_LEN that just does the strlen-like loop > > > manually. I'm not sure what's best. > > > > declare strlen > > > > but i would not worry about this much, if you use such a > > macro you are already outside the well-defined zone.. > > and musl does not need to be nice there > > Declaring strlen is not easy because size_t is not defined. So I guess > we also need an additional #if before including bits/alltypes.h to > define __NEED_size_t... > > This is why I thought a function might be less ugly. Here's a sketch of what it could be: static __inline unsigned long __SUN_LEN(struct sockaddr_un *__s) { unsigned long __i; for (__i=0; __s->sun_path[__i]; __i++); return __i+2; } #define SUN_LEN(s) __SUN_LEN(s) Rich