From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: [PATCH] getcwd: Set errno to EINVAL when size == 0
Date: Tue, 8 Oct 2013 19:48:34 -0400 [thread overview]
Message-ID: <20131008234834.GK20515@brightrain.aerifal.cx> (raw)
In-Reply-To: <525343fb.42e5440a.723b.766b@mx.google.com>
On Mon, Oct 07, 2013 at 04:29:53PM -0700, Michael Forney wrote:
> On Mon, 07 Oct 2013 12:21:57 -0400, Rich Felker <dalias@aerifal.cx> wrote:
> > In principle the kernel should be generating the EINVAL if size is 0,
> > but maybe it does the wrong thing...?
>
> Yeah, from what I could tell, it returns ERANGE in all cases where it
> can't fit the cwd into the buffer.
OK, I think that clears it up then. For now I'll apply your patch
(and at the same time, replace the if branch with a proper block
instead of the ugly comma operator hack) and we can worry about the
glibc issue later.
Rich
prev parent reply other threads:[~2013-10-08 23:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 6:08 Michael Forney
2013-10-07 6:38 ` Jens Gustedt
2013-10-07 16:21 ` Rich Felker
2013-10-07 17:15 ` Justin Cormack
2013-10-07 17:25 ` Rich Felker
2013-10-07 23:29 ` Michael Forney
2013-10-08 23:48 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008234834.GK20515@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).