From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: request: increase TTY_NAME_MAX in limits.h
Date: Sat, 9 Nov 2013 12:38:42 -0500 [thread overview]
Message-ID: <20131109173842.GI24286@brightrain.aerifal.cx> (raw)
In-Reply-To: <527E6EE3.2050109@skarnet.org>
On Sat, Nov 09, 2013 at 05:20:35PM +0000, Laurent Bercot wrote:
>
> >If we change it I think we might as well go with the glibc value of 32
> >rather than just increasing it by 4.
>
> That would be great, thanks :)
>
> I'm honestly surprised that those buffers are so small, even in glibc.
> Sure, it takes up static space, and in practice a small value works for
> most people since it will usually be /dev/something, but since ttyname()
> is not supposed to ever fail with ERANGE or any kind of overflow, I was
> expecting the buffer to be PATH_MAX bytes. Or even dynamically (re)allocated -
> which would pull in malloc(), but text space + a bit of heap space is cheaper
> than static space.
I'm not sure exactly what glibc does; technically, there's no reason
the size of this internal buffer needs to match TTY_NAME_MAX. I just
chose that as a natural size for it. On most systems, where the
ttyname is /dev/xxxxx or /dev/pts/xxxxx, 20 should be sufficient and
32 should leave plenty room. Your situation is a bit odd but there's
no sense in gratuitously breaking it.
Rich
next prev parent reply other threads:[~2013-11-09 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-09 11:07 Laurent Bercot
2013-11-09 16:36 ` Rich Felker
2013-11-09 17:20 ` Laurent Bercot
2013-11-09 17:38 ` Rich Felker [this message]
2013-11-28 16:05 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131109173842.GI24286@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).