mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: [PATCH] Fix dn_comp prototype and add stub
Date: Sat, 23 Nov 2013 16:27:59 -0500	[thread overview]
Message-ID: <20131123212759.GZ24286@brightrain.aerifal.cx> (raw)
In-Reply-To: <20131105142622.GW1685@port70.net>

On Tue, Nov 05, 2013 at 03:26:22PM +0100, Szabolcs Nagy wrote:
> * Michael Forney <mforney@mforney.org> [2013-11-04 21:42:34 -0800]:
> > -int dn_comp(unsigned char *, unsigned char *, int, unsigned char **, unsigned char *, unsigned char **);
> > +int dn_comp(unsigned char *, unsigned char *, int, unsigned char **, unsigned char **);
> 
> bsd and glibc declaration is
> 
> int dn_comp(const char *, u_char *, int, u_char **, u_char **);
> 
> (the linux man is wrong about the first argument)

Indeed. Michael, could you submit a revised version of this patch?

BTW, I think keeping the __-prefixed alias is okay and may actually be
useful for ABI-compat purposes; it looks like glibc's resolv.h exposes
the __-prefixed symbol names (via #define), so glibc-linked binaries
will be looking for the symbol with __.

Rich


  reply	other threads:[~2013-11-23 21:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05  5:42 Michael Forney
2013-11-05 14:26 ` Szabolcs Nagy
2013-11-23 21:27   ` Rich Felker [this message]
2013-11-24  6:33     ` [PATCH v2] " Michael Forney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131123212759.GZ24286@brightrain.aerifal.cx \
    --to=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).