mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: zoneinfo file parsing in __tz.c
Date: Sun, 24 Nov 2013 13:22:21 +0100	[thread overview]
Message-ID: <20131124122221.GK1685@port70.net> (raw)
In-Reply-To: <5291DDA8.7080702@skarnet.org>

* Laurent Bercot <ska-dietlibc@skarnet.org> [2013-11-24 11:06:16 +0000]:
>  While working on leap seconds support, I find the following line in
> do_tzset(), that's supposed to skip the non-supported part of the
> zoneinfo binary format:
>  size_t skip = zi_dotprod(zi, VEC(1,1,8,5,6,1), 6);
> 
>  but zi is the start of the mapped file, and the various numbers
> indicating the sections' length are supposed to be at zi+20, not zi.
>  Is that a bug or have I missed something ?

i think you are not working with latest git then
this is what it says now:

http://git.musl-libc.org/cgit/musl/tree/src/time/__tz.c#n179


  reply	other threads:[~2013-11-24 12:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  1:30 Pending patches/issues before 0.9.15 release? Rich Felker
2013-11-21  9:40 ` Laurent Bercot
2013-11-21 16:39   ` Rich Felker
2013-11-21 16:55     ` Szabolcs Nagy
2013-11-21 19:27     ` Laurent Bercot
2013-11-21 19:44       ` Rich Felker
2013-11-21 20:07         ` Daniel Cegiełka
2013-11-21 20:34           ` Rich Felker
2013-11-21 22:54             ` Laurent Bercot
2013-11-24 11:06         ` zoneinfo file parsing in __tz.c Laurent Bercot
2013-11-24 12:22           ` Szabolcs Nagy [this message]
2013-11-21 22:54       ` Pending patches/issues before 0.9.15 release? Szabolcs Nagy
2013-11-21 23:04         ` Laurent Bercot
2013-11-22  0:18           ` Szabolcs Nagy
2013-11-21 23:05         ` Rich Felker
2013-11-21 19:21 ` John Spencer
2013-11-23 22:02 ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131124122221.GK1685@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).