From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/4318 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: fnmatch and FNM_CASEFOLD Date: Sat, 30 Nov 2013 16:16:12 -0500 Message-ID: <20131130211612.GX24286@brightrain.aerifal.cx> References: <20131129174249.GC24286@brightrain.aerifal.cx> <20131129233417.GK24286@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1385846178 31537 80.91.229.3 (30 Nov 2013 21:16:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Nov 2013 21:16:18 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-4322-gllmg-musl=m.gmane.org@lists.openwall.com Sat Nov 30 22:16:25 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Vmrtp-00074q-0s for gllmg-musl@plane.gmane.org; Sat, 30 Nov 2013 22:16:25 +0100 Original-Received: (qmail 3142 invoked by uid 550); 30 Nov 2013 21:16:24 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 3134 invoked from network); 30 Nov 2013 21:16:24 -0000 Content-Disposition: inline In-Reply-To: <20131129233417.GK24286@brightrain.aerifal.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:4318 Archived-At: On Fri, Nov 29, 2013 at 06:34:17PM -0500, Rich Felker wrote: > On Fri, Nov 29, 2013 at 12:42:49PM -0500, Rich Felker wrote: > > On Fri, Nov 29, 2013 at 05:59:12PM +0800, orc wrote: > > > Hi list, > > > > > > This one really terrorized me well. Musl defines FNM_CASEFOLD in > > > fnmatch.h but really does nothing when this flag is passed to > > > function. This breaks busybox find -iname I believe, instead of file > > > list matching "Test" among with "test" i get only those which > > > contain "test" in their names with -iname "test". Missed lot of > > > files because of it. > > > Wishing this fixed or such define being removed. > > > > I think this is a reasonable request. FNM_CASEFOLD is problematic to > > I'd also like to remove FNM_LEADING_DIR, which is unsupported by musl > and documented in the man page as: > > "This flag is mainly for the internal use of glibc and is > implemented only in certain cases." Unfortunately, Debian codesearch is showing a lot of hits for FNM_LEADING_DIR; I haven't researched whether they're hard or soft dependencies, so if anyone is willing to look into that, it'd be helpful. See: http://codesearch.debian.net/search?q=FNM_LEADING_DIR I'm not opposed to implementing it if it's non-intrusive. Same goes for FNM_CASEFOLD though we need to consider what semantics it should have; nsz has researched what the BSD version does and it's fairly simple but possibly counter-intuitive or possibly "right" depending on your perspective. :-) Unfortunately I'm leaning towards punting on all of these issues until after 1.0, since it's not clear how much build breakage would result from (temporarily) removing the macros, whereas the functional breakage from them being no-ops seems low.. Rich