mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: [PATCHv2] Add support for leap seconds in zoneinfo files
Date: Thu, 5 Dec 2013 06:18:09 +0100	[thread overview]
Message-ID: <20131205051809.GY1685@port70.net> (raw)
In-Reply-To: <529FD33A.8000509@skarnet.org>

* Laurent Bercot <ska-dietlibc@skarnet.org> [2013-12-05 01:13:30 +0000]:
>  
> +static int leapsecs_sub(long long *t)
> +{
> +	long long trans;
> +	int corr;
> +	unsigned int i = __leapsecs_num;
> +	int hit = 0;
> +	for (; i; i--) {
> +		__leapsecs_read(i-1, &trans, &corr);
> +		if (*t >= trans) break;
> +	}
> +	if (i) {
> +		if (*t == trans) hit = 1;
> +		*t -= corr;
> +	}
> +	return hit;
> +}
>  
> +static void leapsecs_add(long long *t, int hit)
> +{
> +	int oldcorr = 0;
> +	unsigned int i = 0;
> +	for (; i < __leapsecs_num; i++) {
> +		long long trans;
> +		int newcorr;
> +		__leapsecs_read(i, &trans, &newcorr);
> +		if (*t < trans) break;
> +		if (!hit || (*t > trans)) {
> +			*t += newcorr - oldcorr;
> +		}
> +		oldcorr = newcorr;
> +	}
> +}
> +

i assume

	hit=leapsecs_sub(&t);
	if(hit) t++;
	leapsecs_add(&t,hit);

should give back the original t,
then the add part can go backwards on the leapsec list instead of forward:

static void leapsecs_add(long long *t, int hit)
{
	long long trans;
	int corr;
	unsigned int i = __leapsecs_num;
	for (; i; i--) {
		__leapsecs_read(i-1, &trans, &corr);
		if (*t+corr > trans) {
			*t += corr;
			// only consider hit at a leapsecond
			if (hit && *t == trans+1) *t--;
			break;
		}
	}
}


  reply	other threads:[~2013-12-05  5:18 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26 18:53 [PATCH] " Laurent Bercot
2013-11-26 18:59 ` Laurent Bercot
2013-11-26 23:32 ` Rich Felker
2013-11-27  1:06   ` Rich Felker
2013-11-27  4:10   ` Laurent Bercot
2013-11-27  4:25     ` Rich Felker
2013-11-27  5:53       ` Laurent Bercot
2013-11-27 18:43         ` Szabolcs Nagy
2013-11-27 20:33           ` Laurent Bercot
2013-12-05  1:13             ` [PATCHv2] " Laurent Bercot
2013-12-05  5:18               ` Szabolcs Nagy [this message]
2013-12-05  8:58                 ` Laurent Bercot
2013-12-05 14:21                   ` Szabolcs Nagy
2013-12-05 14:43               ` Rich Felker
2013-12-05 16:31                 ` Laurent Bercot
2013-12-05 16:40                   ` Rich Felker
2013-12-06  0:36                     ` Laurent Bercot
2013-12-06  0:45                       ` Rich Felker
2013-12-06  1:15                         ` Laurent Bercot
2013-12-06  5:31                           ` Szabolcs Nagy
2013-12-06 10:48                             ` Laurent Bercot
2013-12-06 11:38                               ` Raphael Cohn
2013-12-06 23:29                                 ` Laurent Bercot
2013-12-07  2:31                                   ` Rich Felker
2013-12-07  4:02                                     ` Szabolcs Nagy
2013-12-07  8:52                                     ` Laurent Bercot
2013-12-06  6:29                           ` Rich Felker
2013-12-06 10:37                             ` Laurent Bercot
2013-12-06 12:50                               ` Rich Felker
2013-12-06 13:27                                 ` Szabolcs Nagy
2013-12-06 15:48                                   ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131205051809.GY1685@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).