From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/4451 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Re: Removing sbrk and brk Date: Fri, 3 Jan 2014 13:19:06 -0500 Message-ID: <20140103181906.GV24286@brightrain.aerifal.cx> References: <20131221234041.GA13204@brightrain.aerifal.cx> <20131222184855.GS1685@port70.net> <20131223044609.GZ24286@brightrain.aerifal.cx> <20140102220302.GR24286@brightrain.aerifal.cx> <20140103173301.GU24286@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1388773154 10554 80.91.229.3 (3 Jan 2014 18:19:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Jan 2014 18:19:14 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-4455-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jan 03 19:19:22 2014 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Vz9L5-0002vP-RZ for gllmg-musl@plane.gmane.org; Fri, 03 Jan 2014 19:19:19 +0100 Original-Received: (qmail 12001 invoked by uid 550); 3 Jan 2014 18:19:19 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 11993 invoked from network); 3 Jan 2014 18:19:19 -0000 Content-Disposition: inline In-Reply-To: <20140103173301.GU24286@brightrain.aerifal.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:4451 Archived-At: On Fri, Jan 03, 2014 at 12:33:01PM -0500, Rich Felker wrote: > hodge-podge of copy-and-paste from various legacy code. I suspect > omalloc is considerably higher quality than a lot of the things those > two implementations copied, but from casual inspection, it doesn't > look anywhere near as small or high-performance as musl's. > > > http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/stdlib/malloc.c Quick summary of omalloc: - Uses mmap directly for allocations of at least PAGE_SIZE (vs musl which only uses mmap directly past 128k/256k limit). - Rounds all allocation sizes up to a power of 2 (vs musl which has exact sizes for all mod-16-aligned sizes up to 512 bytes, or mod-32-aligned up to 1024 bytes on 64-bit, and above that every 1/4 unit between successive powers of 2). - Global lock (vs musl which uses local, per-bin locks, allowing allocations of different sizes not to touch the same locks). - Allocations smaller than PAGE_SIZE are made by allocating a whole page of same-size objects that cannot be merged or resized in-place (vs musl which splits and combines free ranges as needed from a large, growable heap). Overall my assessment is that omalloc is _simple_ (in some ways simpler than musl's), but looks to have much worse fragmentation properties, much worse performance properties (both syscall overhead and locking come to mind), and no other clear advantages. Rich