mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: Am I using PRIxPTR wrong?  Musl-libc complains, glibc doesn't
Date: Tue, 14 Jan 2014 15:59:16 -0500	[thread overview]
Message-ID: <20140114205916.GC24286@brightrain.aerifal.cx> (raw)
In-Reply-To: <loom.20140114T212850-606@post.gmane.org>

On Tue, Jan 14, 2014 at 08:36:36PM +0000, David Wuertele wrote:
> /* test.c - demo difference between glibc and musl-libc wrt PRIxPTR
> **
> ** Both native (x86_64 glibc) and target (arm musl-libc) define
> ** PRIxPTR as "lx", but uintptr_t as unsigned int:
> **
> **   $ gcc -E test.c | grep uintptr_t
> **   typedef unsigned long int uintptr_t;
> **     printf ("main is at 0x%""l" "x""\n", (uintptr_t) main);
> **
> **   $ arm-linux-musleabishf-gcc -E test.c | grep uintptr_t
> **   typedef unsigned int uintptr_t;
> **     printf ("main is at 0x%""lx""\n", (uintptr_t) main);
> **
> ** While native gcc doesn't complain, target gcc does:
> ** 
> **   $ gcc -c test.c -Wformat
> **
> **   $ arm-linux-musleabishf-gcc -c test.c -Wformat
> **   test.c: In function ‘main’:
> **   test.c:6:3: warning: format ‘%lx’ expects argument of type
> ** ‘long unsigned int’, but argument 2 has type ‘unsigned int’ [-Wformat]
> */
> 
> #include <stdio.h>
> #include <inttypes.h>
> int
> main (int ac, char *av[])
> {
>   printf ("main is at 0x%"PRIxPTR"\n", (uintptr_t) main);
>   return 0;
> }
> 

I suspect your compiler was miscompiled for a non-EABI ARM
configuration; perhaps putting "shf" on the end of the maching tuple
string messed it up. I can't find the exact logic for UINTPTR_TYPE,
but my copy of gcc-4.7.3/gcc/config/arm/arm.h contains:

#define SIZE_TYPE (TARGET_AAPCS_BASED ? "unsigned int" : "long unsigned int")

suggesting that for AAPCS-based (EABI) targets, the correct type for
pointer-sized integer types is int, whereas on legacy targets, a long
type was used.

Note that if your compiler was miscompiled for non-EABI, many other
things will be wrong, like alignment/padding of 64-bit arguments, etc.

Rich


  reply	other threads:[~2014-01-14 20:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14 20:36 David Wuertele
2014-01-14 20:59 ` Rich Felker [this message]
2014-01-14 21:06 ` Szabolcs Nagy
2014-01-14 21:20   ` Rich Felker
2014-01-14 21:37     ` David Wuertele
2014-01-14 21:45       ` Rich Felker
2014-01-14 21:34   ` David Wuertele

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140114205916.GC24286@brightrain.aerifal.cx \
    --to=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).