From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/4571 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: getprotobynumber() misses IPv6 support Date: Thu, 13 Feb 2014 12:23:19 -0500 Message-ID: <20140213172319.GB184@brightrain.aerifal.cx> References: <172ce60f-6695-46c8-9312-bfa1bb15674e@email.android.com> <28fd9d9e-81ad-41aa-a96f-98e95a123ec2@email.android.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1392312206 3710 80.91.229.3 (13 Feb 2014 17:23:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Feb 2014 17:23:26 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-4575-gllmg-musl=m.gmane.org@lists.openwall.com Thu Feb 13 18:23:34 2014 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1WE00c-0001UR-Bl for gllmg-musl@plane.gmane.org; Thu, 13 Feb 2014 18:23:34 +0100 Original-Received: (qmail 22497 invoked by uid 550); 13 Feb 2014 17:23:33 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 22489 invoked from network); 13 Feb 2014 17:23:33 -0000 Content-Disposition: inline In-Reply-To: <28fd9d9e-81ad-41aa-a96f-98e95a123ec2@email.android.com> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:4571 Archived-At: On Thu, Feb 13, 2014 at 09:25:42PM +0800, orc wrote: > 1 февраля 2014 г. 17:28:55 KRAT, orc пишет: > >getprotobynumber() should return valid data at least for IPPROTO_IPV6 > >and IPPROTO_ICMPV6. Without this, getprptobynumber() seeks somewhere > >beyond limits and causes segfaults somewhere, somewhere returns random > >string (is there a typo between "\377raw" and "\0\0" missing comma?). > > > >"do we really need all these??" > >At least core IPv6 is needed :-) > > Any thoughts on this? Yes, I meant to reply earlier. More interesting is that you caught the missing comma bug. :-) I'll check it over and apply it now if it's ok or get back to you soon. Rich