From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/4662 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Last call for bugfixes for 1.0 Date: Sat, 15 Mar 2014 18:26:51 -0400 Message-ID: <20140315222651.GB26358@brightrain.aerifal.cx> References: <20140315075223.GA27718@brightrain.aerifal.cx> <5324C625.5020303@gcom.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1394922420 3408 80.91.229.3 (15 Mar 2014 22:27:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 15 Mar 2014 22:27:00 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-4666-gllmg-musl=m.gmane.org@lists.openwall.com Sat Mar 15 23:27:09 2014 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1WOx2r-0006TW-51 for gllmg-musl@plane.gmane.org; Sat, 15 Mar 2014 23:27:09 +0100 Original-Received: (qmail 2039 invoked by uid 550); 15 Mar 2014 22:27:07 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 2031 invoked from network); 15 Mar 2014 22:27:07 -0000 Content-Disposition: inline In-Reply-To: <5324C625.5020303@gcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:4662 Archived-At: On Sat, Mar 15, 2014 at 04:29:09PM -0500, David Grothe wrote: > Rich: > > I notice that the library does not have a routine for rawmemchr. I Unfortunately this is outside the scope of the freeze, but I think we could add it right after the release. > suppose it could just be defined as memchr(ptr, c, INT_MAX). No, it definitely can't. This could easily return the wrong value (e.g. if c first occurs past offset INT_MAX) and it also invokes UB (since there's no guarantee memchr does not read past the first instance of c). Rich