From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/4680 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: vDSO parsing bug? Date: Thu, 20 Mar 2014 13:02:45 -0400 Message-ID: <20140320170245.GC26358@brightrain.aerifal.cx> References: Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1395334978 20031 80.91.229.3 (20 Mar 2014 17:02:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Mar 2014 17:02:58 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-4684-gllmg-musl=m.gmane.org@lists.openwall.com Thu Mar 20 18:03:06 2014 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1WQgMs-0006iO-CO for gllmg-musl@plane.gmane.org; Thu, 20 Mar 2014 18:02:58 +0100 Original-Received: (qmail 3095 invoked by uid 550); 20 Mar 2014 17:02:57 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 3087 invoked from network); 20 Mar 2014 17:02:57 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:4680 Archived-At: On Thu, Mar 20, 2014 at 08:23:24AM -0700, Andy Lutomirski wrote: > Hi- > > It looks like musl can't handle vDSO images with more than one PT_LOAD > segment. Both glibc and the reference code in > Documentation/vDSO/parse_vdso.c can handle this. I'm not clear on what you think is wrong. The computation of vdso->base? That's all musl uses the PT_LOAD header for. > It's not currently an issue, since I don't think that any > architectures provide such a vDSO, but they might want to in the > future. > > Also, using the name "linux-gate.so.1" is sort of wrong on x86_64, > where the convention is "linux-vdso.so.1". Wouldn't it be better to > just read the name out of the SONAME header? Yes, that sounds like a better solution. I just didn't realize it was an option. BTW the vdso usage is currently broken as far as I can tell. Due to the way musl binds function references at link time, the weak-alias setup that's intended to allow the vdso functions to interpose does not actually work. I'm thinking it might be better to avoid accessing the vdso through the dynamic linker like this and simply parsing it directly in code that can be used in static-linked programs too. Then it's not clear to me whether the dynamic linker would even need to report the vdso in the link map, but maybe it still should to assist gdb...? I'd welcome further input on this topic. Rich