From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: printf issues
Date: Fri, 4 Apr 2014 20:54:13 +0200 [thread overview]
Message-ID: <20140404185413.GH3034@port70.net> (raw)
In-Reply-To: <CANv4PN=LsCLdOmgUwx5JD=cCVj3+KWDj3c-KRexjLNY4xZShPw@mail.gmail.com>
* Morten Welinder <mwelinder@gmail.com> [2014-04-04 13:42:30 -0400]:
> It looks like the LDBL_EPSILON version could be used in
>
> roundl.c
> modfl.c
> ceill.c
> floorl.c
>
> in the definition of TOINT instead of enumerating choices for
> LDBL_MANT_DIG. It's basically the same thing going on
yes, that would be a bit nicer
(although other long double formats won't be supported anytime soon)
(note that in the future these implementations may need to change
the current versions raise inexact flag if result!=input, but the
next version of the floating-point extension standard for c
will require suppressing inexact, which i dont know how to do
with simple arithmetics efficiently without accessing the fenv..)
> While I was looking for that, I noticed that this modfl fallback looks
> problematic. Even if long double and double are the same thing
> under the hood, I don't think you can cast pointers like that and
> assume it works. It needs a temporary.
>
> #if LDBL_MANT_DIG == 53 && LDBL_MAX_EXP == 1024
> long double modfl(long double x, long double *iptr)
> {
> return modf(x, (double *)iptr);
> }
yes, this is an aliasing violation, nice catch
the original idea was to allow tail call opt for these wrappers,
so they are a single branch instruction, we should fix it but
i think we can rely on that the ptr representations are the same:
long double modfl(long double x, long double *iptr)
{
union {long double *ld; double *d;} u = {iptr};
return modf(x, u.d);
}
next prev parent reply other threads:[~2014-04-04 18:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 13:32 Morten Welinder
2014-04-04 14:12 ` Rich Felker
2014-04-04 14:15 ` Szabolcs Nagy
2014-04-04 14:35 ` Morten Welinder
2014-04-04 14:56 ` Szabolcs Nagy
2014-04-04 15:07 ` Rich Felker
2014-04-04 17:42 ` Morten Welinder
2014-04-04 18:54 ` Szabolcs Nagy [this message]
2014-04-04 20:01 ` Morten Welinder
2014-04-04 20:22 ` Morten Welinder
2014-04-04 21:08 ` Rich Felker
2014-04-04 22:50 ` Morten Welinder
2014-04-05 0:01 ` Morten Welinder
2014-04-05 1:41 ` Rich Felker
2014-04-07 7:29 ` Rich Felker
2014-04-07 13:40 ` Morten Welinder
2014-04-07 14:13 ` Morten Welinder
2014-04-07 15:36 ` Szabolcs Nagy
2014-04-07 18:04 ` Rich Felker
2014-04-04 20:54 ` Szabolcs Nagy
2014-04-04 21:02 ` Rich Felker
2014-04-05 2:08 ` Morten Welinder
2014-04-05 2:50 ` Rich Felker
2014-04-06 23:07 ` Szabolcs Nagy
2014-04-04 21:00 ` Rich Felker
2014-04-04 21:10 ` Szabolcs Nagy
2014-04-04 20:58 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404185413.GH3034@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).