From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: printf issues
Date: Fri, 4 Apr 2014 16:58:08 -0400 [thread overview]
Message-ID: <20140404205808.GP26358@brightrain.aerifal.cx> (raw)
In-Reply-To: <CANv4PN=LsCLdOmgUwx5JD=cCVj3+KWDj3c-KRexjLNY4xZShPw@mail.gmail.com>
On Fri, Apr 04, 2014 at 01:42:30PM -0400, Morten Welinder wrote:
> > I _would_ like this code to be easily adaptable for use outside libc
> > if somebody wants it
>
> FYI, I have been doing just that for Gnumeric in a variant that always
> rounds ties away from zero. Two changes would help with making
> the code fit seamlessly into other environments.
>
> 1. Make "i" in fmt_fp unsigned. It's used in connection with
> unsigned values only.
I don't object, but what's the motivation?
> 2. Make "char *s" used to hold "NAN" etc. "const char *s".
Indeed, this is harmless. I assume it's to satisfy that ugly option
that changes the type of string literals from char[] to const char[]?
BTW that option actually just got a lot more problematic with C11; now
that C has _Generic, it potentially changes the semantics of a program
rather than just helping generate warnings.
> Neither of these should make any difference in what the function
> actually does.
>
> I have run tens of millions random numbers through this function
> looking for differences between it and glibc. The extra 0s from "%g"
> is the only problem observed.
Nice. I was actually thinking of some numerical tests we could run on
huge random samples, for instance using using theorems about
properties of the digits of the decimal expansion (e.g. n%3==0 iff the
sum of the digits mod 3==0; this works for diadic-rational 'multiples
of 3' too).
> It looks like the LDBL_EPSILON version could be used in
>
> roundl.c
> modfl.c
> ceill.c
> floorl.c
>
> in the definition of TOINT instead of enumerating choices for
> LDBL_MANT_DIG. It's basically the same thing going on
> there.
Indeed, this would be a welcome change.
> While I was looking for that, I noticed that this modfl fallback looks
> problematic. Even if long double and double are the same thing
> under the hood, I don't think you can cast pointers like that and
> assume it works. It needs a temporary.
>
> #if LDBL_MANT_DIG == 53 && LDBL_MAX_EXP == 1024
> long double modfl(long double x, long double *iptr)
> {
> return modf(x, (double *)iptr);
> }
Agreed. This is UB (an aliasing violation) and should be fixed even if
it makes the function a few bytes larger/a few cycles slower.
Rich
prev parent reply other threads:[~2014-04-04 20:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 13:32 Morten Welinder
2014-04-04 14:12 ` Rich Felker
2014-04-04 14:15 ` Szabolcs Nagy
2014-04-04 14:35 ` Morten Welinder
2014-04-04 14:56 ` Szabolcs Nagy
2014-04-04 15:07 ` Rich Felker
2014-04-04 17:42 ` Morten Welinder
2014-04-04 18:54 ` Szabolcs Nagy
2014-04-04 20:01 ` Morten Welinder
2014-04-04 20:22 ` Morten Welinder
2014-04-04 21:08 ` Rich Felker
2014-04-04 22:50 ` Morten Welinder
2014-04-05 0:01 ` Morten Welinder
2014-04-05 1:41 ` Rich Felker
2014-04-07 7:29 ` Rich Felker
2014-04-07 13:40 ` Morten Welinder
2014-04-07 14:13 ` Morten Welinder
2014-04-07 15:36 ` Szabolcs Nagy
2014-04-07 18:04 ` Rich Felker
2014-04-04 20:54 ` Szabolcs Nagy
2014-04-04 21:02 ` Rich Felker
2014-04-05 2:08 ` Morten Welinder
2014-04-05 2:50 ` Rich Felker
2014-04-06 23:07 ` Szabolcs Nagy
2014-04-04 21:00 ` Rich Felker
2014-04-04 21:10 ` Szabolcs Nagy
2014-04-04 20:58 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404205808.GP26358@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).