From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: printf issues
Date: Mon, 7 Apr 2014 03:29:30 -0400 [thread overview]
Message-ID: <20140407072930.GB26358@brightrain.aerifal.cx> (raw)
In-Reply-To: <CANv4PNmMWBnvh_B25L=R_sv5w9jbCxA+tK8+c9i9qcSgc_ucJw@mail.gmail.com>
On Fri, Apr 04, 2014 at 08:01:00PM -0400, Morten Welinder wrote:
> I *think* the right fix is to add the following "if' statement into
> the rounding loop:
>
> while (*d > 999999999) {
> *d--=0;
> if (d < a) *--a = 0;
> (*d)++;
> }
>
> This also ought to make the d<a test afterwards unnecessary. But
> more tests would be better.
After re-studying the code, I think this is the correct fix, and I've
committed the fix to git. I also fixed the bug where %g failed to trim
trailing zeros.
Rich
next prev parent reply other threads:[~2014-04-07 7:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 13:32 Morten Welinder
2014-04-04 14:12 ` Rich Felker
2014-04-04 14:15 ` Szabolcs Nagy
2014-04-04 14:35 ` Morten Welinder
2014-04-04 14:56 ` Szabolcs Nagy
2014-04-04 15:07 ` Rich Felker
2014-04-04 17:42 ` Morten Welinder
2014-04-04 18:54 ` Szabolcs Nagy
2014-04-04 20:01 ` Morten Welinder
2014-04-04 20:22 ` Morten Welinder
2014-04-04 21:08 ` Rich Felker
2014-04-04 22:50 ` Morten Welinder
2014-04-05 0:01 ` Morten Welinder
2014-04-05 1:41 ` Rich Felker
2014-04-07 7:29 ` Rich Felker [this message]
2014-04-07 13:40 ` Morten Welinder
2014-04-07 14:13 ` Morten Welinder
2014-04-07 15:36 ` Szabolcs Nagy
2014-04-07 18:04 ` Rich Felker
2014-04-04 20:54 ` Szabolcs Nagy
2014-04-04 21:02 ` Rich Felker
2014-04-05 2:08 ` Morten Welinder
2014-04-05 2:50 ` Rich Felker
2014-04-06 23:07 ` Szabolcs Nagy
2014-04-04 21:00 ` Rich Felker
2014-04-04 21:10 ` Szabolcs Nagy
2014-04-04 20:58 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407072930.GB26358@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).