mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: src/string/wcsstr.c doesn't work
Date: Fri, 18 Apr 2014 17:49:32 -0400	[thread overview]
Message-ID: <20140418214932.GO26358@brightrain.aerifal.cx> (raw)
In-Reply-To: <CACeDTm2UGpq+bjUAFfAVsrxDMw-Ej7BoS3jBikF=-3T6Rt77Eg@mail.gmail.com>

On Fri, Apr 18, 2014 at 06:41:46PM +0200, Yves Bastide wrote:
> Hi,
> 
> twoway_wcsstr doesn't (always) work with periodic needles. With the
> attached example
> 
> haystack = L"playing play play play always";
> needle = L"play play play";
> 
> mem0 = 9, ms = 3; thus, after a left-half mismatch on "playing", mem is 9 and
>     for (k = ms + 1; k>mem && n[k - 1] == h[k - 1]; k--);
> terminates immediately.

Thanks! Immediate termination of this loop is correct, but the
subsequent conditional should have been treating it as success rather
than failure. Fix committed.

Rich


      reply	other threads:[~2014-04-18 21:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-18 16:41 Yves Bastide
2014-04-18 21:49 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140418214932.GO26358@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).